Opened 12 years ago

Closed 9 years ago

Last modified 8 years ago

#1309 closed defect (obsolete)

Can't find unfullscreen button

Reported by: erikos Owned by: erikos
Priority: Immediate Milestone:
Component: Browse Version: Git as of bugdate
Severity: Critical Keywords: relnote
Cc: sayamindu Distribution/OS: Unspecified
Bug Status: New

Description

After I hit fullscreen, I can not get back to find the fullscreen button. Sayamindu, does it have something to do with #1102?

Change History (17)

comment:1 Changed 12 years ago by erikos

  • Priority changed from Unspecified by Maintainer to Immediate

comment:2 Changed 12 years ago by sayamindu

I am a bit confused by this - some activities work, while the others do not. I vote that this be set a blocker.

comment:3 Changed 12 years ago by erikos

  • Severity changed from Critical to Blocker

comment:4 Changed 12 years ago by sayamindu

Here's what I found:

The reason why the pointer motion is not being detected in case of Terminal is that the motion-notify handler in VTE (the terminal widget) returns TRUE, effectively stopping any other handler for motion-notify being invoked. I guess there is some similar issue in Mozilla as well.
This is buggy behaviour - see this mail from Owen Taylor, where he mentions:

- MOTION_NOTIFY, PROXIMITY_IN, PROXIMITY_OUT

  These indicate state changes rather than action. A signal handler
  for one of these that returns TRUE is likely a bug. 

To confirm, I recompiled VTE with the handler returning FALSE, and with that, the unfullscreen button returned like a charm.

In such a scenario, we either have to

  • Revert the change, and rely on activities themselves to provide a unfullscreen button when they want the current functionality
  • Figure out some other way to do this

comment:5 Changed 12 years ago by sayamindu

comment:6 follow-up: Changed 12 years ago by erikos

Sayamindu, thanks very much for digging this up. Ideally, we would fix it upstream, if we want to go down the road of using motion_notify.

I just checked what other apps do in full screen mode. In Firefox you have to go to the top of the screen in order to to get a toolbar back - similar to our frame behavior. Doing the same would clash with the frame, so maybe not the best option.
In the gnome terminal, a little toolbar stays open where one can go back to 'normal' mode. This would mean not floating button - though we would loose a little part of the screen.

When showing the button on mouse move, we assume that the user uses the page up and down buttons to scroll - for example in the browser. Not sure this will always be the case.

Tricky :/

comment:7 in reply to: ↑ 6 Changed 12 years ago by tomeu

Replying to erikos:

Sayamindu, thanks very much for digging this up. Ideally, we would fix it upstream, if we want to go down the road of using motion_notify.

Let's fix upstreams and lobby distros to apply the patch as soon as it gets committed?

comment:8 Changed 12 years ago by tomeu

In the meantime, we can release note it and comment on the workaround (using the accelerator).

comment:11 Changed 12 years ago by alsroot

Not sure we should leave it as is, if 3 of fructose activities have issue with unfullscreen button. We can dirty fix it for now.

comment:12 Changed 12 years ago by alsroot

Terminal #1402

comment:13 Changed 12 years ago by alsroot

For fructose, only Browse still has this issue, we can't fix it like in #1402, maybe xulrunner has API(non-gtk) for mouse movements?

comment:14 Changed 12 years ago by erikos

There is movement (review+) in the upstream bug. So it looks good that this is fixed soon.

comment:15 Changed 12 years ago by erikos

  • Keywords relnote added
  • Severity changed from Blocker to Critical

Let's add it to the release notes and hope the upstream fix gets included soon.

comment:16 Changed 9 years ago by manuq

  • Resolution set to obsolete
  • Status changed from new to closed

This is not the case in current Sugar/Browse. Closing this as obsolete.

comment:17 Changed 8 years ago by dnarvaez

  • Milestone 0.86 deleted

Milestone 0.86 deleted

Note: See TracTickets for help on using tickets.