Opened 10 years ago

Closed 10 years ago

Last modified 6 years ago

#1304 closed defect (fixed)

Secondary toolbar widget should set a minimum height

Reported by: garycmartin Owned by: alsroot
Priority: Unspecified by Maintainer Milestone:
Component: Sugar Version: Git as of bugdate
Severity: Unspecified Keywords: r+
Cc: alsroot Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description

When a secondary toolbar doesn't have icon tool buttons its size shrinks to fit and looks wrong. Currently I'm having to put in Activity hacks to force the secondary toolbar larger (invisible separator using sugar.graphics.style.GRID_CELL_SIZE). See line 386 for an example hack:

http://git.sugarlabs.org/projects/write/repos/garycmartins-toolbar-clone/blobs/master/toolbar.py

I like the idea of having no maximum height, this could be a rare though useful feature to keep, but a minimum height seems important for toolbar visual consistency and preventing jumping canvases as you toggle between secondary toolbars.

Attachments (1)

sugar-1304.patch (1.2 KB) - added by alsroot 10 years ago.

Download all attachments as: .zip

Change History (5)

Changed 10 years ago by alsroot

comment:1 Changed 10 years ago by alsroot

  • Keywords r? added

comment:2 Changed 10 years ago by tomeu

  • Keywords r+ added; r? removed
  • Owner changed from tomeu to alsroot
  • Status changed from new to assigned

comment:4 Changed 6 years ago by dnarvaez

  • Milestone 0.86 deleted

Milestone 0.86 deleted

Note: See TracTickets for help on using tickets.