Opened 12 years ago

Closed 8 years ago

Last modified 8 years ago

#1201 closed task (obsolete)

preserve uid property in sugar.datastore.find()

Reported by: sascha_silbe Owned by: erikos
Priority: Unspecified by Maintainer Milestone:
Component: Sugar Version: Git as of bugdate
Severity: Unspecified Keywords:
Cc: tomeu Distribution/OS: Unspecified
Bug Status: New

Description (last modified by sascha_silbe)

Except for find() all functions in sugar.datastore.datastore preserve the 'uid' property in the metadata; write() even sets it on create().
This patch (based on mainline/master) stops find() from removing that property so that it's now consistently set regardless of which function inside sugar.datastore.datastore created the DSObject / DSMetadata (find(), get(), write(); get_properties() from #1197).

Attachments (2)

0001-don-t-remove-uid-property-from-find-results.patch (929 bytes) - added by sascha_silbe 12 years ago.
preserve uid property in sugar.datastore.find()
0001-don-t-remove-uid-property-from-find-results-rebased.patch (974 bytes) - added by sascha_silbe 12 years ago.
same patch on top of #1197

Download all attachments as: .zip

Change History (9)

Changed 12 years ago by sascha_silbe

preserve uid property in sugar.datastore.find()

comment:1 Changed 12 years ago by sascha_silbe

  • Description modified (diff)

Changed 12 years ago by sascha_silbe

same patch on top of #1197

comment:2 Changed 12 years ago by sascha_silbe

  • Component changed from sugar-datastore to sugar-toolkit
  • Owner changed from tomeu to erikos

comment:3 Changed 12 years ago by tomeu

  • Keywords r! added; r? removed

Not sure why the uid property is set after a create in the metadata, but we already have it as object_id in DSObject. Does it make sense to have this info both in the metadata and in the DSObject?

If nobody really needs this change, I would prefer to defer it to 0.88.

comment:4 Changed 11 years ago by sascha_silbe

  • Cc tomeu added
  • Keywords r! removed
  • Milestone changed from 0.86 to 0.90

Maybe we should do the opposite then: To make sure data store implementation details don't leak to activities, let's filter out uid on every call that modifies the metadata.

comment:5 Changed 8 years ago by dnarvaez

  • Component changed from sugar-toolkit to Sugar

comment:6 Changed 8 years ago by dnarvaez

  • Resolution set to obsolete
  • Status changed from new to closed

Obsolete patches, unclear if it's the right thing to do anyway.

comment:7 Changed 8 years ago by dnarvaez

  • Milestone 0.90 deleted

Milestone 0.90 deleted

Note: See TracTickets for help on using tickets.