#1109 closed task (fixed)
PEP8 compliance fixes
Reported by: | sascha_silbe | Owned by: | erikos |
---|---|---|---|
Priority: | Unspecified by Maintainer | Milestone: | Unspecified |
Component: | Sugar | Version: | Git as of bugdate |
Severity: | Trivial | Keywords: | r+ |
Cc: | tomeu | Distribution/OS: | Unspecified |
Bug Status: | Assigned |
Description
Similar to #1108, the attached patch fixes most of the complains from pep8.py, but this time only for some of the files (mostly the ones changed in my own branch).
Attachments (2)
Change History (8)
Changed 14 years ago by sascha_silbe
comment:1 follow-up: ↓ 3 Changed 14 years ago by erikos
- Bug Status changed from New to Assigned
- Keywords r! added; r? removed
Thanks for the patch. I am just working on figuring out how much we should apply to the pep guidelines. Of course, I agree, that we should. But we would have to change a lot of code in all the modules, and we should agree we are all on the same page before.
For example: 2 lines before between classes...
comment:2 Changed 14 years ago by sascha_silbe
- Cc tomeu added
- Keywords r? added; r! removed
As a start I've now done only the EOL fixes (but for all files this time). I suppose that doesn't require a lot of discussion: Whitespace on end of line is redundant in virtually any source file and will get automatically removed by many editors, especially if you change anything on the same line. The latter point makes working with EOL-containing files hard if you want to back out single changes (because the whitespace changes will stay).
"make check" doesn't report anything it didn't report before (a lot of intltool complains).
comment:3 in reply to: ↑ 1 Changed 14 years ago by tomeu
Replying to erikos:
Thanks for the patch. I am just working on figuring out how much we should apply to the pep guidelines. Of course, I agree, that we should. But we would have to change a lot of code in all the modules, and we should agree we are all on the same page before.
For example: 2 lines before between classes...
Yeah, I don't care about the particular rules that are enforced, for me what is important is that it's consistent across the whole codebase and that can be checked automatically.
comment:4 Changed 14 years ago by erikos
- Keywords r! added; r? removed
Patch must be rebased - otherwise looks good.
comment:5 Changed 14 years ago by erikos
- Keywords r+ added; r! removed
- Resolution set to fixed
- Status changed from new to closed
pushed by sascha.
comment:6 Changed 10 years ago by dnarvaez
- Component changed from sugar-toolkit to Sugar
PEP8 compliance fixes for some of the files in sugar-toolkit