Chat: shows "share or invite" hint even on resume of shared instance

[sascha_silbe]

Chat shows the usual hint about sharing with neighbourhood or inviting someone even if a previously-shared instance in resumed.

[FGrose]

The Off-line/Shared highlight times out. It may be a feature to remind the user.

More discussion on this design...

[erikos]

I would like to see this fixed - might consider looking at #525 as well.

[eben]

I'm not sure I see this as a bug. There might be better ways to handle it, but removing the alert might not be it.

A better system would actually recognize that the instance has been shared in the past, and provide the option to resume the chat, automatically inviting the former participants. In fact, this could/should be a Sugar thing (opposed to a Chat thing), by which any activity resumed gave an option (in the launcher!?) to resume it with the former participants, thus automatically sending them invitations to join. That approach prevents redundant code, limits developer hassle, and keeps the invitation step in the trusted shell.

If all of that was built within Sugar, then I would see the presence of the current alert a "bug". Chat should then recognize when an instance is a fresh one and provide the alert, and skip it for resumed instances (aware that they've already been prompted to share) with the assumption that the intent is to review or copy the conversation, and not continue it.

[sascha_silbe]

I consider the current behaviour a bug. There are two different indicators for the "shared" status and they disagree:
1. The "Private/Neighbourhood" listbox that's greyed out and shows "Neighbourhood", i.e. indicating that the current session is shared.
2. The "you need to go online" hint that indicates the current session is NOT shared.

I don't know for sure which one is correct, but they obviously can't both be right.

[erikos]

I would like to see that fixed - can someone look into that? (I think Morgan is busy with other stuff currently)

[alsroot]

Replying to eben:

A better system would actually recognize that the instance has been shared in the past, and provide the option to resume the chat, automatically inviting the former participants. In fact, this could/should be a Sugar thing (opposed to a Chat thing), by which any activity resumed gave an option (in the launcher!?) to resume it with the former participants, thus automatically sending them invitations to join. That approach prevents redundant code, limits developer hassle, and keeps the invitation step in the trusted shell.

I've created #669 for that reason

[erikos]

As Eben pointed out, Sugar should ideally offer the option to re-share an entry that has been shared before. As currently entries are shared directly (like previously shared Browse or Write) we should do the same in Chat and do the propper fix for 0.86 I guess.

So I think the patch provided by Aleksey looks good. What do you think, Tomeu?

[erikos]

Tomeu gave as well the r+ on irc. I have filed #671 for the better handling in 0.86 described by Eben.

[erikos]

Morgan, can either you release a new version of chat - or give one of us access to your repo?

[alsroot]

Well, I was thinking a lot comparing all pro and contras..
and finally decided to apply this not trivial patch!

[erikos]

Where was it pushed to? It does not seem to be in git.

[alsroot]

Replying to erikos:

Where was it pushed to? It does not seem to be in git.

today is 1st April