Views: implement long-press behavior

[erikos]

long-press should be equivalent to a right click, bring up the full Palette.

[erikos]

We could pack the logic into the EventIcon directly like we do for the invoker.

diff --git a/src/sugar3/graphics/icon.py b/src/sugar3/graphics/icon.py
index 9008f3f..2391860 100644
--- a/src/sugar3/graphics/icon.py
+++ b/src/sugar3/graphics/icon.py
@@ -32,6 +32,8 @@ from gi.repository import GdkPixbuf
 from gi.repository import Rsvg
 import cairo
 
+from gi.repository import SugarGestures
+
 from sugar3.graphics import style
 from sugar3.graphics.xocolor import XoColor
 from sugar3.util import LRU
@@ -497,6 +499,12 @@ class EventIcon(Gtk.EventBox):
         from sugar3.graphics.palette import CursorInvoker
         self._palette_invoker = CursorInvoker()
         self._palette_invoker.attach(self)
+
+        gesture_controller = SugarGestures.LongPressController()
+        gesture_controller.connect('pressed', self.__long_pressed_cb)
+        gesture_controller.attach(self,
+                                  SugarGestures.EventControllerFlags.NONE)
+
         self.connect('destroy', self.__destroy_cb)
 
     def do_draw(self, cr):
@@ -678,6 +686,9 @@ class EventIcon(Gtk.EventBox):
 
         self.set_palette(Palette(text))
 
+    def __long_pressed_cb(self, controller, x, y):
+        self.props.palette.popup(immediate=True, state=1)
+

[erikos]

We need this as well for the Activity list in the Frame, tap does switch directly to the Activity, long-press should reveal the Palette.

[erikos]

Patch for the toolit that adds the long-press eventcontroller to the EventIcon

[erikos]

While testing I found out that on long press the Palette pops up and directly down again. This is because we do use a Gtk.Menu in the Views Palette and that does popdown on a long press and actually as well a long click (you can test this with a long click with the buttons as well).

The above patch tries to use our custom Palette for the AP icon. An issue with that approach is that currently you can not dismiss such a Palette by clicking somewhere around it. As well it does not automatically go away when a menu item is selected (see as well the 'remove' option for a usb key device in the Frame).

[erikos]

add events to dismiss Palette

[erikos]

make detach available

[erikos]

CursorInvoker: add long-press

[erikos]

SugarLongPress gesture controller: remove animation

[erikos]

Carlos reviewed the event-controller patches, pushed them as:

​http://git.sugarlabs.org/sugar-toolkit-gtk3/sugar-toolkit-gtk3/commit/1d9965c972625318bc885afc97d7e443c6619eef

​http://git.sugarlabs.org/sugar-toolkit-gtk3/sugar-toolkit-gtk3/commit/080f25e73b082c9750ad647be9cf73a1e2001794

[erikos]

FavoritesView: switch ActivityPalette from GTK.Menu to custom menu

[erikos]

CurrentActivityPalette: switch ActivityPalette from GTK.Menu to custom menu

[erikos]

test for long-press gesture

[erikos]

JournalPalette: make sure to popdown when we switch to the Journal

[erikos]

BuddyMenu: switch from GTK.Menu to custom menu

[erikos]

NetworkView: add the custom SugarPalette instead of the GTK.Menu based one

[manuq]

All those went in, impressive work Simon.

In the favorites view, spiral layout, we have drag and drop code that breaks the long press behaviour, is being tracked here: ​http://bugs.sugarlabs.org/ticket/4014

[manuq]

Ups, reopenning because we still need long-press for the Activity list in the Frame.

[erikos]

I preferred to open new tickets for the critical missing long-press behaviours: #4127 #4128

[greenfeld]

Every main Sugar view seems to support both short and long taps in Sugar 0.98.2/13.1.0 os20.

[dnarvaez]

Milestone 0.98 deleted