Speak adds ".." after each language choice

[greenfeld]

Speak-41 on OLPC 12.1.0 os13 & os14 adds ".." after each language choice in the drop-down selection dialog.

Speak-33 on OLPC 11.3.1 os885 does not do this.

Both XOs tested were running Sugar in Spanish.

[cjl]

It might have something to do with this line of code.

​http://git.sugarlabs.org/speak/mainline/blobs/master/activity.py#line126

[cjl]

123 self.voices = ComboBox()
124 for name in sorted(voice.allVoices().keys()):
125 vn = voice.allVoices()[name]
126 n = name [ : 26 ] + ".."
127 self.voices.append_item(vn, n)

[RafaelOrtiz]

I really like it with the '..' it gives the visual reference that there are more LANG in the combo.

[alsroot]

Replying to RafaelOrtiz:

I really like it with the '..' it gives the visual reference that there are more LANG in the combo.

But it looks confusing, because eclipses in gtk says "there are more symbols, in the same string, to show", i.e., it is not a common practice that looks like a bug and better to avoid it.

[walter]

Further, ellipsis is usually three "puntos" ... so it for some reason you decide to keep it, please add another dot.

[RafaelOrtiz]

Ok seems better to avoid then. Following walter and aleksey's comments.

[walter]

I fixed this in the up-coming release. I use ... when the language name is longer than 26 characters. Otherwise there is no ellipsis.