Ticket #3622 (closed defect: fixed)

Opened 12 months ago

Last modified 11 months ago

Incorrect PDF filename is shown in the tab title

Reported by: humitos Owned by: manuq
Priority: Unspecified by Maintainer Milestone: 0.96
Component: Browse Version: Unspecified
Severity: Unspecified Keywords: 12.1.0, patch, olpc-test-passed
Cc: humitos, erikos, manuq Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description (last modified by humitos) (diff)

Steps to reproduce it:

  1. Open Browse
  2. Open a PDF file without title (for example:  http://library.rit.edu/pubs/guides/mla.pdf)
  3. Save it in the Journal by clicking the button at the bottom
  4. Close Browse
  5. Go to the Journal
  6. Open the last Browse instance

Issue:

The tab with the PDF file shows the filename (hashed) took from the datastore. In this case: db3371a3-dccb-488b-84c7-3d8962a6f2f3.pdf

Expected behavior:

I think it should show the original filename (mla.pdf).

Attachments

pdf_title_fix.patch Download (0.8 KB) - added by manuq 12 months ago.
0002-Display-the-filename-for-untitled-PDFs-stored-in-the.patch Download (1.4 KB) - added by manuq 12 months ago.

Change History

Changed 12 months ago by humitos

  • description modified (diff)

Changed 12 months ago by manuq

  • owner changed from erikos to manuq
  • status changed from new to assigned

Changed 12 months ago by manuq

Changed 12 months ago by manuq

The attached patch fixes the issue. However, I would like to improve it, removing the line with the comment "#ugly".

Changed 12 months ago by manuq

Seems that the ugly line is needed.

Changed 12 months ago by manuq

Changed 12 months ago by manuq

  • keywords 12.1.0, patch added

Changed 12 months ago by humitos

Good! This works!

I tested this on XO 1.75 os11 and git version of Browse.

Changed 12 months ago by erikos

Works, thanks for the patch, please push.

Changed 12 months ago by manuq

  • keywords patch, olpc-test-pending added; patch removed
  • status changed from assigned to closed
  • resolution set to fixed

Pushed as 2009091c304fa892727d90c23e93257ffa150d6b

Changed 11 months ago by greenfeld

  • keywords olpc-test-passed added; olpc-test-pending removed

The journal's filename for the PDF is used if present (as long as you are not hovering over the URL line to see the  journal:// URI, which still shows the hash tag).

Tested in OLPC 12.1.0 os16/Browse-140.

Note: See TracTickets for help on using tickets.