Browse is displaying "Loading..." in the tab that triggers a download or a PDF load

[manuq]

TestCase:

• open a link with a file to download, like  http://dev.laptop.org/~manuq/theming_examples.tar.gz
• the tab label and the url entry should not change

Thay are changing now to "Loading...".

[manuq]

When browse handles a pdf or a download, the loading status of the webview in the current tab changes to WEBKIT_LOAD_PROVISIONAL and then to WEBKIT_LOAD_FAILED. I will take a look at Epiphany code to see if this is expected, as WebKit documentation is not telling me.

fix_loading.patch is a fix for this bug, if the "failed" status is expected.

[manuq]

Yes, what Ephy does is similar, it just unsets the "Loading..." title when failed. Sending the patch to the mailing list.

[humitos]

I think it works properly. I'm going to explain what happens here:

1. Open Browse
2. Go to this url ticket
3. Click on the link file (in the description)
4. The tab title changes to "Loading..."
5. When the download is done, the tab title changes again to title of the webpage.

If this is the expected behavior, this patch works! :)

I tested this on XO 1.75 os11 and git version of Browse

[erikos]

This does work as expected. Good work to look at the epiphany code for reference. Please push that one.

[manuq]

Pushed as d6c56f8184de2b3980aca34fb644d2a8f0f4b64f

[greenfeld]

This is fixed in 12.1.0 os16/Browse-140.