Ticket #3565 (closed defect: fixed)

Opened 13 months ago

Last modified 5 months ago

Theme scroll button in the tray

Reported by: erikos Owned by: manuq
Priority: High Milestone: 0.98
Component: sugar-artwork Version: Git as of bugdate
Severity: Major Keywords: regression, r+, olpc-test-passed
Cc: erikos Distribution/OS: Unspecified
Bug Status: New

Description

see how it looks like at the moment:  http://bugs.sugarlabs.org/attachment/ticket/3522/bookmarks_tray.png

and how it could look like (example from Record), note that Record has a different behavior as well as the icons are shown all the time but changes the state active/inactive:
 http://bugs.sugarlabs.org/attachment/ticket/3522/tray_record.png

 http://bugs.sugarlabs.org/attachment/ticket/3522/tray_record_can_scroll.png

Not a regression, but if there is an easy fix, let's do it.

Attachments

3565-preliminar.patch Download (3.1 KB) - added by manuq 7 months ago.
Preliminar patch
0001-Tray-wrap-them-in-EventBoxes-in-order-to-make-them-t.patch Download (4.3 KB) - added by manuq 6 months ago.
Candidate patch for 1.
0001-Tray-Set-background-color-SL-3565.patch Download (0.9 KB) - added by manuq 6 months ago.
Artwork patch for 2.

Change History

Changed 12 months ago by erikos

  • milestone changed from 0.96 to 0.98

Moving out that we fix the regressions first.

Changed 8 months ago by manuq

  • cc erikos added
  • owner changed from erikos to manuq
  • status changed from new to assigned

Changed 7 months ago by manuq

Preliminar patch

Changed 7 months ago by manuq

Sugar trays are gtk boxes that pack buttons in both ends, and a gtk viewport in the middle. The viewport packs a gtk toolbar.

What we need here is 1. paint the background of those boxes, and 2. style the buttons.

For 2 we just need to add the gtype_name and the attached patch does so.

For 1 we have to convert the boxes to EventBoxes because otherwise the background is not themeable:  https://bugzilla.gnome.org/show_bug.cgi?id=678790

I did so in the attached patch but now I have an issue in the _size_allocate_cb of _TrayViewport:

(tray.py:18161): Gtk-WARNING **: gtk_widget_size_allocate(): attempt to allocate widget with width -1280350453 and height 1

So I need fix that. Then, a patch for artwork is trivial.

Runing the testcase in toolkit-gtk3 tests/graphics/test.py is being useful to work on this.

Changed 6 months ago by manuq

  • priority changed from Unspecified by Maintainer to High

Changed 6 months ago by manuq

  • keywords regression added

Changed 6 months ago by manuq

Candidate patch for 1.

Changed 6 months ago by manuq

Artwork patch for 2.

Changed 6 months ago by manuq

  • keywords regression, r? added; regression removed

The two patches, one for artwork and one for toolkit, make the style correct again.

Changed 6 months ago by manuq

  • keywords r+, olpc-test-pending added; r? removed
  • status changed from assigned to closed
  • resolution set to fixed

Pushed toolkit d418d1cb artwork 8b24e667 .

Changed 6 months ago by erikos

When testing #3565 I came across #4279. Your theme changes do works well, thanks for this.

Changed 5 months ago by greenfeld

  • keywords olpc-test-passed added; olpc-test-pending removed

The favorites bar in Browse now has sugar-like dark-background arrows in Sugar 0.98.3 (although the oblong oval highlight when touched/hovered looks a bit odd).

Note: See TracTickets for help on using tickets.