Ticket #3419 (closed defect: fixed)

Opened 14 months ago

Last modified 10 months ago

Consider dropping libxml2 usage

Reported by: dsd Owned by: humitos
Priority: Low Milestone: Unspecified by Release Team
Component: GetBooks Version: Unspecified
Severity: Unspecified Keywords:
Cc: humitos Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description

GetBooks uses libxml2-python, and this is an external library.

Could it be switched to using the xml classes that are included in Python? This way we could consider dropping the libxml2-python usage from the sugar platform and OLPC builds.

Attachments

0001-Drop-libxml2-SL-3419.patch Download (3.0 KB) - added by humitos 11 months ago.
0001-Drop-libxml2-SL-3419.2.patch Download (3.0 KB) - added by humitos 10 months ago.
New version - v2

Change History

Changed 11 months ago by humitos

  • cc humitos added

Changed 11 months ago by humitos

Changed 11 months ago by godiard

We need do the following tests:

* Navigate the catalog: Click on "public domain books",and select different categories, up and down. The list of books should be updated.

* When click in any book, the image and data in the bottom side of the screen should be updated.

* Download the book. Try different formats if available.

* Search a title or author.

* Change the source combo to "Internet Archive" and do a search.

* Download a book from Internet Archive.

Changed 10 months ago by humitos

All of this test that you mentioned here passed without any problem after applying this patch.

Changed 10 months ago by humitos

  • owner changed from godiard to humitos
  • status changed from new to accepted

Changed 10 months ago by humitos

New version - v2

Changed 10 months ago by godiard

  • status changed from accepted to closed
  • resolution set to fixed

I can't see any change in your second patch.

I applied a version with the changes we talked (move _xmldoc and _eroot to get_full_language_name method, and make them method variables)

Note: See TracTickets for help on using tickets.