Ticket #3411 (closed defect: fixed)

Opened 14 months ago

Last modified 11 months ago

Browse GTK3: Upload files - Browse opens file chooser instead of journal entry selector

Reported by: manuq Owned by: dsd
Priority: High Milestone: 0.96
Component: Browse Version: Git as of bugdate
Severity: Major Keywords: 12.1.0, upstream, patch, olpc-test-passed
Cc: erikos Distribution/OS: Unspecified
Bug Status: Assigned

Description

When an upload is requested, WebKitGTK+ opens the default GTK file chooser dialog, GtkFileChooser, but we need to open the Sugar object chooser instead.

WebKitGTK+ should provide an "upload-requested" signal, so we can handle it. This needs to be done in WebKitGTK+.

We already asked on the list for ideas [1]. There was some interest and a patch was done [2], but for WebKit2, and still not commited.

For the record, the html field that should send the signal is <form><input type=file> .

[1]  https://lists.webkit.org/pipermail/webkit-gtk/2012-January/000894.html
[2]  https://bugs.webkit.org/show_bug.cgi?id=78491

Attachments

org.laptop.WebActivity-1.log Download (3.0 KB) - added by manuq 12 months ago.
dbus error while testing the webkitgtk test RPM

Change History

Changed 14 months ago by manuq

Gonzalo suggested csotts's preloading hack as a workaround. We can either add a workaround, or wait for WebKit2, as the fix is almost there for landing upstream.

Changed 13 months ago by manuq

  • priority changed from Unspecified by Maintainer to High

Changed 13 months ago by manuq

  • summary changed from Browse GTK3: Upload files to Browse GTK3: Upload files - Browse opens file chooser instead of journal entry selector

Changed 13 months ago by manuq

'run-file-chooser' signal has landed in WebKitGTK+, but for WebKit2:

 http://trac.webkit.org/changeset/115627

Changed 13 months ago by manuq

  • keywords 12.1.0, upstream added; 12.1.0 removed

Changed 12 months ago by manuq

dsd is doing great work upstream, backporting the filechooser signal to WebKit1. Tracked here:  https://bugs.webkit.org/show_bug.cgi?id=87283

Changed 12 months ago by dsd

  • owner changed from manuq to dsd
  • status changed from new to assigned

Changed 12 months ago by dsd

Test RPMs with the patch included:  http://dev.laptop.org/~dsd/20120604/

Changed 12 months ago by erikos

  • severity changed from Unspecified to Major
  • status_field changed from Unconfirmed to Assigned

Daniel, Manuel was saying you had as well a Browse patch already laying around for that? If so, can you please attach here?

Changed 12 months ago by manuq

Daniel, I tested the RPM in XO-1.5 and patched Browse with the patch you sent to the list, I get an error in dbus.connection.py, log attached.

Changed 12 months ago by manuq

dbus error while testing the webkitgtk test RPM

Changed 12 months ago by manuq

Forgot to mention the build, sorry. Is olpc latest build os12, XO-1.5 and Browse from git patched.

Changed 12 months ago by dsd

Looks like you are running an old sugar-toolkit-gtk3

Changed 11 months ago by manuq

Thanks, tested in os13. I've reviewed it and looks good. I will push with Simon's ACK.

Changed 11 months ago by manuq

  • keywords upstream, patch, olpc-test-pending added; upstream removed
  • status changed from assigned to closed
  • resolution set to fixed

Pushed, is in Browse 140.

Changed 11 months ago by greenfeld

  • keywords olpc-test-passed added; olpc-test-pending removed

The Sugar upload selector was tested with Gmail on XO-1.5 and XO-1.75 with 12.1.0 os16/Browse-140.

The filename chosen to upload from the Journal seemed to make sense.

Note: See TracTickets for help on using tickets.