Hovering Home list view un-favorited star provides confusing feedback

[FGrose]

Observed on os8 on an XO-1.75

When one hovers an un-favorited item star in the Home list view, the star takes on the favorite colors, so there is no feedback if it is clicked.

Previously, the star would fill with gray on hover, and become colored if clicked. This was better.

[erikos]

Hmm, maybe if the item is favored (star is colored) it should just do the inverse when hovering over it and uncolor the star?

[FGrose]

Replying to erikos:

Hmm, maybe if the item is favored (star is colored) it should just do the inverse when hovering over it and uncolor the star?

The gray shading is less than ideal because the image contrast difference varies with the chosen colors and may be insufficient (an accessibility problem, especially for small items and less-than-ideal visual conditions). I would prefer appropriately sized, gray, rounded borders, like those used to highlight the activity icons in the regular Home view. This would work on the stars for both the favorited and un-favorited activities.

[FGrose]

From ticket #3090 -  http://git.sugarlabs.org/sugar/mainline/commit/cc64af8187b26a5aafa0c43d84c794ab071d8312?diffmode=inline :

... hovering over the icon should reflect the visual change that will occur
once you click on the icon: the icon will be colored in the owners color
when the item is favored, therefore we need to color it in the owners
color as well when we hover over the icon.

The objective should be reworded to the following:

... hovering over the icon should visually reflect that a change that will occur
once you click the icon: ..., therefore we need to highlight the icon in a
visually clear manner when we hover the icon.

As noted above, graying has accessibility issues. A gray, rounded box outline would work well for both colored and uncolored (favorited and un-favorited activity) icons.

•  Design Team discussion - 2012-07-23

[garycmartin]

We could stitch over to the grey rounded rectangle mouse over, press, visual feedback we use on the Home view for Activities (currently broken after the GTK3 sugar shell port, you'll need to look on an 12.1 build). The star icon would only change colour when it was pressed, providing the needed feedback.

[erikos]

see #3989 for the press feedback for the star icon.