Checkbox/Radio button outline on black panel disappears in mouseover selection highlight

[FGrose]

Observed in Soas-200902041922.iso (and earlier versions).

The gray outline of the checkbox disappears into the gray highlight of the mouseover selection.

This is an unexpected loss of focus for the user.

A white, lighter or darker gray outline could be used or revealed on the highlight action to visually polish this panel.

The uncheck action highlight is OK.

[erikos]

Agreed this should be changed, i will have a look.

[erikos]

Benjamin, is that something we can/should handle in the theme?

[FGrose]

This checkbox was used on the Home, Favorites view, Resume default, but that is option is no longer revealed. Don't know where another checkbox on a black panel is used currently, but the issue will return when that need arises, unless the graphic is tuned in the theme for this situation.

[erikos]

This is not a current issue anymore as the checkbox has been removed. However we should fix this as we might run into it again.

[sascha_silbe]

Bulk change distribution=SoaS -> component=SoaS

[sdz]

This is a Sugar issue that got accidentally assigned to SoaS during an auto-tag. Reassigning.

[ishan]

I am presently handling the bug-  http://bugs.sugarlabs.org/ticket/305.

I have made the changes in the file sugar-100.gtkrc present under sugar-jhbuild/source/sugar-artworks/gtk/themes but it seems that while making the patch, git does not identifies such files so we have to add the file manually using git add -f sugar-100.gtkrc and commit the changes. But when the patch is made it shows the entire file as added in the patch file. For reference check  http://pastebin.com/VE0TakJX which shows the patch file made.

Any suggestions on how can i just list the changes i made in the file instead of the entire file?

[sascha_silbe]

Replying to ishan:

I am presently handling the bug-  http://bugs.sugarlabs.org/ticket/305.

I hope so if your commenting on exactly this ticket. ;)

I have made the changes in the file sugar-100.gtkrc present under sugar-jhbuild/source/sugar-artworks/gtk/themes but it seems that while making the patch, git does not identifies such files so we have to add the file manually using git add -f sugar-100.gtkrc and commit the changes. But when the patch is made it shows the entire file as added in the patch file. For reference check  http://pastebin.com/VE0TakJX which shows the patch file made.

Please attach files to the ticket instead of mentioning a pastebin URL. Attachments will stay available, whereas pastebin regularly erases content. I have confirmed your user account, so you should be able to attach files in the future.

As to your problem, sugar-72.gtkrc and sugar-100.gtkrc are automatically created from gtkrc.em during the build process. Check out  gtk/theme/Makefile.am. You need to change the source file (gtkrc.em) instead.

[benzea]

OK, never reacted earlier ...

Unfortunately I am not running any remotely recent version of sugar anywhere right now, so I am not going to look more closely into this. It should be relativel simple to change the color in general, the question is under what circumstances.
ie. how is the background color changed on the black panel, and is there a sane way for the theme to know that this happened (or maybe it already knows, but the style to change the color in the checkbox is just missing). Unfortunately it is hard to tell anything from the pastebin post, as it contains the whole file, and I am not familiar enough with the theme currently.

[smparrish]

Replying to sascha_silbe:

Replying to ishan:

I am presently handling the bug-  http://bugs.sugarlabs.org/ticket/305.

I hope so if your commenting on exactly this ticket. ;)

I have made the changes in the file sugar-100.gtkrc present under sugar-jhbuild/source/sugar-artworks/gtk/themes but it seems that while making the patch, git does not identifies such files so we have to add the file manually using git add -f sugar-100.gtkrc and commit the changes. But when the patch is made it shows the entire file as added in the patch file. For reference check  http://pastebin.com/VE0TakJX which shows the patch file made.

Please attach files to the ticket instead of mentioning a pastebin URL. Attachments will stay available, whereas pastebin regularly erases content. I have confirmed your user account, so you should be able to attach files in the future.

As to your problem, sugar-72.gtkrc and sugar-100.gtkrc are automatically created from gtkrc.em during the build process. Check out  gtk/theme/Makefile.am. You need to change the source file (gtkrc.em) instead.

Ishan as Sascha pointed out you have modified the wrong file. sugar-100.gtkrc is created during the build process so your changes will never be applied. You need to Check out  gtk/theme/Makefile.am. You need to change the source file (gtkrc.em) instead.

Please work with gtkrc.em and submit an updated patch.

Thanks

Steven Parrish
Dextrose Project Manager

[ishan]

Steven

I have already made the patch using gtkrc.em .

Please refer to  http://lists.sugarlabs.org/archive/sugar-devel/2010-September/026732.html
to review the patch.

[FGrose]

Restoring the original description (it got blanked out).

[benzea]

Unconditionally changing the color seems quite intrusive to me.

Attaching a screenshot, is this the case where the problem arises?
(Note that at least one bug can be seen in the shot: the background of the checkbox should be white, but is not because of the treeviews style.)

[benzea]

screenshot of the software update list

[sascha_silbe]

The original instance of this bug is gone, so we need a test case (a minimal GTK program) to reproduce it.
The existing patch looks like it would make the problem worse instead of fixing it, but only the test case can really show.

[FGrose]

An example of this styling problem is available in Browse by secondary-button-clicking in the address bar. See 'gray radio button' screenshot, attached.

[godiard]

This happen again in sugar 0.98, and worst, the test case displayed on the last screenshot show a artifact in the radiobuttons.

[benzea]

But it is using GTK+ 3.x now, instead of 2.x?

I would say it is important to know in what widgets it happens. It should be pretty simple to specifically style the checkbox inside eg. a menu item. Not sure right now how this is done in GTK+ 3.x though.