Opened 13 years ago
Closed 13 years ago
#2870 closed defect (fixed)
Use bundle_id instead of service_name and exec instead of class in activity.info
| Reported by: | erikos | Owned by: | godiard |
|---|---|---|---|
| Priority: | Unspecified by Maintainer | Milestone: | Unspecified |
| Component: | ActivityTeam | Version: | Git as of bugdate |
| Severity: | Unspecified | Keywords: | 11.3.0 |
| Cc: | garycmartin, dsd | Distribution/OS: | OLPC |
| Bug Status: | New |
Description (last modified by godiard)
WARNING:root:bundle_name deprecated, now comes from activity.info
service_name = org.laptop.Oficina
bundle_id = org.laptop.WebActivity
the class line should be replaced by:
exec = sugar-activity class.to.startuo.the.activity
Change History (17)
comment:1 Changed 13 years ago by godiard
comment:2 Changed 13 years ago by godiard
Also, we need update the information in the wikis.
The only reference I have found is http://wiki.sugarlabs.org/go/0.90/Notes
but there are a lot of places saying we need to put service_name
comment:3 Changed 13 years ago by RafaelOrtiz
Comments on some activities.
log: a patch has this fixed, mainline has to include it.
pippy: has fix on mainline needs packaging.
terminal: has a patch on sugar-devel and merge request.
words: has fix on mainline needs packaging
comment:4 Changed 13 years ago by RafaelOrtiz
Typing turtle has this fixed on mainline: needs packaing.
comment:5 Changed 13 years ago by godiard
I have modified all I could:
Updated list:
[gonzalo@nautilus honey]$ grep service_name */*/activity/activity.info clock/mainline/activity/activity.info:service_name = tv.alterna.Clock distance/acoustic-measure-activity/activity/activity.info:service_name = org.laptop.AcousticMeasure finance/mainline/activity/activity.info:service_name = org.laptop.community.Finance labyrinth/mainline/activity/activity.info:service_name = org.gnome.Labyrinth physics/mainline/activity/activity.info:service_name = org.laptop.physics terminal/mainline/activity/activity.info:service_name = org.laptop.Terminal watchme/mainline/activity/activity.info:service_name = org.sugarlabs.Watchme
Probably is a good idea change the activities using class instead of exec too:
[gonzalo@nautilus honey]$ grep class */*/activity/activity.info distance/acoustic-measure-activity/activity/activity.info:class = activity.AcousticMeasureActivity jukebox/mainline/activity/activity.info:class = jukeboxactivity.JukeboxActivity maze/mainline/activity/activity.info:class = activity.MazeActivity record/mainline/activity/activity.info:class = record.Record stopwatch/stopwatch/activity/activity.info:class = activity.StopWatchActivity words/words-activity/activity/activity.info:class = pippy_app.WordsActivity
I will send a mail to sugar-devel asking help
comment:6 follow-up: ↓ 7 Changed 13 years ago by erikos
Thanks Gonzalo and activity team, you rock! And yes it would be good to update the information on the wiki as well.
So, as the fields have been deprecated for a while (announced again in 0.90), I would like to remove the fields from the [API http://git.sugarlabs.org/sugar-toolkit/mainline/blobs/master/src/sugar/bundle/activitybundle.py#line154] in 0.94 completely. Does that sound good to you guys from the activity side?
comment:7 in reply to: ↑ 6 Changed 13 years ago by godiard
- Keywords 11.2.0 added
So, as the fields have been deprecated for a while (announced again in 0.90), I would like to remove the fields from the [API http://git.sugarlabs.org/sugar-toolkit/mainline/blobs/master/src/sugar/bundle/activitybundle.py#line154] in 0.94 completely. Does that sound good to you guys from the activity side?
I think we need more time.
I am checkingour 44 activities, but in ASLO there are 357 activities.
comment:8 Changed 13 years ago by RafaelOrtiz
+1 with gonzalo, we don't wish to have hundreds of activities failing for deprecations.
comment:9 Changed 13 years ago by erikos
- Component changed from Paint to ActivityTeam
- Keywords 11.3.0 added; 11.2.0 removed
- Owner changed from godiard to garycmartin
Maybe we can finish this work this cycle. (putting this in the ActivityTeam component as it is a global Activity ticket)
comment:10 Changed 13 years ago by erikos
- Owner changed from garycmartin to godiard
- Status changed from new to assigned
comment:11 Changed 13 years ago by godiard
- Cc garycmartin dsd added
Updated status:
[gonzalo@aronax honey]$ grep service_name */*/activity/activity.info clock/mainline/activity/activity.info:service_name = tv.alterna.Clock distance/acoustic-measure-activity/activity/activity.info:service_name = org.laptop.AcousticMeasure finance/mainline/activity/activity.info:service_name = org.laptop.community.Finance labyrinth/mainline/activity/activity.info:service_name = org.gnome.Labyrinth physics/mainline/activity/activity.info:service_name = org.laptop.physics
[gonzalo@aronax honey]$ grep class */*/activity/activity.info distance/acoustic-measure-activity/activity/activity.info:class = activity.AcousticMeasureActivity record/mainline/activity/activity.info:class = record.Record
CC to garycmartin and dsd because Clock, Labyrinth and Physics are from Gary and Record is from Daniel
comment:12 Changed 13 years ago by godiard
Changed Finance
Only Clock, Dstance, Labyrinth, Physics and Record pending....
comment:13 Changed 13 years ago by garycmartin
Clock, Physics, Labyrinth mainline now tweaked to use bundle_id instead of service_name
comment:14 Changed 13 years ago by godiard
The only pending activity is Record!
comment:15 Changed 13 years ago by godiard
- Summary changed from Use bundle_id instead of service_name in activity.info to Use bundle_id instead of service_name and exec instead of class in activity.info
comment:16 Changed 13 years ago by godiard
- Description modified (diff)
comment:17 Changed 13 years ago by godiard
- Resolution set to fixed
- Status changed from assigned to closed
Record activity was fixed.
The ticket can be closed.
More activities to see: