Ticket #226 (closed enhancement: fixed)

Opened 4 years ago

Last modified 4 years ago

Journal no matching entry found does not meet spec

Reported by: erikos Owned by: tomeu
Priority: minor Milestone: 0.86
Component: journal Version: 0.83.x
Severity: Blocker Keywords:
Cc: unmadindu, eben Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description

The message displayed is 'No matching entry', and the 'Clear Search' option is missing.

 http://wiki.laptop.org/go/Designs/Journal#11

Change History

Changed 4 years ago by tomeu

  • cc unmadindu, eben added

would need to break the string freeze, opinions?

Changed 4 years ago by tomeu

(09:41:59 AM) tomeu: unmadindu: for fixing this, would need to break the string freeze: http://dev.sugarlabs.org/ticket/226 what's your opinion on that?
(09:43:12 AM) unmadindu: tomeu: 1 string extra ?
(09:43:56 AM) tomeu: unmadindu: add 1 and change 1 is what says the ticket
(09:44:09 AM) tomeu: unmadindu: but we could just add 1 and leave the change for the next release
(09:44:35 AM) unmadindu: tomeu: second one seems a good option

Changed 4 years ago by tomeu

  • milestone set to 0.86

Added the button in  http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/eae73448

Changing the existing string will need to happen in a future release because of the string freeze.

Changed 4 years ago by eben

  • status changed from new to closed
  • distribution set to Unspecified
  • resolution set to fixed
  • severity set to Blocker
  • status_field set to Unconfimed

Nice work. I think the message string is fine as is. In fact, I think I might have added that in a patch of my own, if I recall correctly. I'm closing this, since the button is already in place.

Note: See TracTickets for help on using tickets.