Opened 5 years ago

Closed 19 months ago

#1959 closed enhancement (fixed)

Clock Activity should have a "knob" to move the hands.

Reported by: cjl Owned by: garycmartin
Priority: Unspecified by Maintainer Milestone: Unspecified
Component: Clock Version: Unspecified
Severity: Unspecified Keywords:
Cc: humitos Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description

Migrating this ticket from OLPC Trac
http://dev.laptop.org/ticket/5255

Description:
Back when I was a kid, my teacher took the wall clock in the classroom, took out batteries, and show us the clock face. During the classs, she moved hands by the knob behind the face and went like: "so can you tell what time is this clock showing?", or "say 'stop' when the face shows 90 minutes after 'now'" and rotated knob, etc. The computer version of "Clock Activity" should be able to do these stuff. The clock should be stoppable, and controllable by the user with perhaps a dial on screen.

It would be nicer if one can set three hands independently so you can make a impossible configuration to tell it is impossible (but probably this is optional.)

Attachments (12)

Change History (29)

comment:1 Changed 3 years ago by RafaelOrtiz

Indeed this would be nice feature to add.

Changed 3 years ago by manuq

Patch that adds the feature.

comment:2 Changed 3 years ago by manuq

The patch needs the previously sent patch for porting to Cairo: http://lists.sugarlabs.org/archive/sugar-devel/2011-December/034993.html

The attached patch adds a new toggle button in the toolbar, with the graphic of a hand. When activated, the hands of the clock stop moving and can be grabbed. When deactivated, the clock returns to the actual behaviour, showing the current time.

comment:3 Changed 3 years ago by manuq

The port to Cairo is now tracked in #3454 .

comment:4 Changed 3 years ago by garycmartin

Currently too slow on XO-1.75 with the Cairo patch #3454, especially in the nice clock display mode (and not great peformance on the simple clock either). Will need to make performance improvements before landing (e.g. dirty rects tracking, remove fancy alpha from the nice clock.svg).

Changed 3 years ago by humitos

New patch to make it applies in the latest git version

comment:5 Changed 3 years ago by humitos

Sorry about the attachment, I was trying to attach that patch to another ticket.

comment:6 Changed 3 years ago by humitos

  • Cc humitos added

comment:7 follow-up: Changed 3 years ago by humitos

I tested this patch on XO 1.5 os9 and works very slow.

comment:8 in reply to: ↑ 7 Changed 22 months ago by manuq

Replying to humitos:

I tested this patch on XO 1.5 os9 and works very slow.

This was an issue in "port to Cairo" which already landed with a fix for the slowness, I have closed that ticket (#3454).

comment:9 Changed 22 months ago by manuq

I have updated the patch to current git. Did it in six separate patches for easier review. Sorry for uploading number 5 twice.

comment:10 Changed 22 months ago by manuq

7th patch is a performance boost for the simple clock. 8th patch fixes a traceback in the resize callback (not introduced by this patches).

XO bundle for testing: http://dev.laptop.org/~manuq/Clock-12.3.xo

Changed 22 months ago by manuq

This one should be applied instead of 0006-Don-t-display-time-in-full-letters-in-grab-hands-mod.patch - does not conflict

comment:11 Changed 22 months ago by manuq

I think the last patch improves the feature a lot. Thanks Simon for the recommendation.

New XO bundle for testing: http://dev.laptop.org/~manuq/Clock-12.4.xo

comment:12 Changed 22 months ago by erikos

Excellent work Manuel, this feature gets a really good pedagogical one!

As you have stated in one comment the 'written and spoken' clock has difficulties when it comes to AM vs PM.

1:30 AM - Es la una y media de la mañana.
1:45 AM - Son las dos menos cuarto de la mañana.
1:45 PM - Son las dos menos cuarto de la tarde.

(http://www.spanishspanish.com/time/clock_web.html)

Interface wise one could have a button that let's you switch between AM/PM in the grabbed clock.

Grabbing the clock hands is nice as an effect, though I must say that I had difficulties sometimes getting the result that I want. For example 1:45 was impossible to get to (at least in Spanish), it always left at 1:44 or 1:46. Maybe adding a number box like in the example shown is a good option as well. Is not as sexy but might be easier precise interface wise.

There are different ways of telling the numbers, a simple one and a more complex one. Let's look at French (6:50): "Il est sept heures moins dix" or "Il est six heures cinquante", (see [http://french.about.com/od/vocabulary/a/tellingtime.htm one guide). The AM/PM information might be implied (surroundings) or you can add the "du matin/de l'après-midi/du soir" to clarify.

And the more precise one using the 24hours model: "Il est dix-neuf heures moins dix" or "Il est dix-huit heures cinquante". (see this guide).

We have to see what makes sense to put in there.

One more point I want to raise is, that it is terrific that the grab feature works as well with speak. The sound with speak is not great though, hard to understand and get the pronunciation right. A killer feature would be to have the clock spoken by a native and maybe with enough compression this would not be as bad to add size wise. A vérifier.

comment:13 Changed 22 months ago by erikos

Had some more thinking to the above: I would suggest three inputs, one for the time (either clock hand grabbing or combo boxes hour|minutes), one for AM/PM and one for 12/24. If there are several ways of saying it like described above, I would display both.

6:50 | PM | 12: Il est sept heures moins dix du matin.

6:50 | AM | 12: Il est sept heures moins dix du soir.

6:50 | AM | 24: "Il est dix-huit heures cinquante" "Il est dix-neuf heures moins dix"

In the example I like how the background changes to indicate day or night. Would be neat to do similar.

comment:14 Changed 22 months ago by manuq

Update:

comment:15 follow-up: Changed 21 months ago by godiard

Gary, any chance to get these changes included? Tell us if you need help with activity maintenance.

comment:16 in reply to: ↑ 15 Changed 21 months ago by garycmartin

Replying to godiard:

Gary, any chance to get these changes included? Tell us if you need help with activity maintenance.

Hi Gonzalo, I've been landing patches (including Manuq's grabbing-hands branch), but still have a number of edge case bugs with the manual grab hand mode I'm trying to fix. I really am trying to get a release out of this before it drives me crazy! ;)

comment:17 Changed 19 months ago by manuq

  • Resolution set to fixed
  • Status changed from new to closed

This landed! Thanks! Closing.

Note: See TracTickets for help on using tickets.