Ticket #1768 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

3G - cleanup layout in contro panel section

Reported by: erikos Owned by: tomeu
Priority: Unspecified by Maintainer Milestone: 0.88
Component: sugar Version: Unspecified
Severity: Major Keywords: r+
Cc: Distribution/OS: Unspecified
Bug Status: New

Description

What does the patch do:
- shifts the section to the left side
- aligns the labels like we do in the 'about me' section
- adds explanation string (mainly taken from nm-applet)
- writes out abbreviations

a) This is very important for consistency.
b) I hope this helps in better understanding what the section is for

Attachments

1768_3G_cp_section_cleanup.patch Download (4.3 KB) - added by erikos 3 years ago.

Change History

Changed 3 years ago by erikos

Changed 3 years ago by tomeu

  • keywords r+ added; r? removed

Looks good to me, we need to ask for a string freeze exception. Have you considered adding a add_label_to_group(group) method instead of making the whole label public?

Changed 3 years ago by erikos

  • status changed from new to closed
  • resolution set to fixed

Thanks Martin for the patch!

Pushed as:  http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/d491e9e87da2fdcd8c522b811909670fdf9f9731

Changed 3 years ago by erikos

Oups wrong ticket...

The commit is:  http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/aabd92d565f96c1d553c2e1ef4701b46ce8ed61d

Note: See TracTickets for help on using tickets.