3G: Error when trying to connect without gsm settings

[erikos]

Scenario: No settings are done in the Control Panel. GSM Device is connected. Connect button is pressed in the gsm device palette.

We create a gsm connection in model.networks.py by default. When one tries to connect without any settings made the call "network.find_gsm_connection()" will return a connection - the default one, and tries to connect. We catch a runtime error in that case.

I think we should not create a connection unless settings in the CP section have been made.

[erikos]

I guess this one is for: Martin -> Martincho -> Tincho -> tch :)

[tch]

that patch avoids gsm connection loading if it doesn't have the basic configuration and raises an exception if the user tries to connect under that circumstance.

Still needs to show the errors in a graphical-friendly way...whenever we decide what mechanism to use.

[erikos]

Thanks for the patch! Please don't forget to add the 'r?' in the keywords :) I think that makes more sense now. I will have another in depth look at the patch tomorrow. And maybe we can talk as well about how we will display errors.

[erikos]

Please watch for indentation (pylint would have caught this error):

W0311:695: Bad indentation. Found 6 spaces, expected 8

The baud_rate should be a constant.

Do we need to rais an error in "gsm_connect_cb" ? Can we not just log that?

[erikos]

Ok, done after discussion with Martin on irc and pushed as:  http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/ca362631e8a492b1aea04b4311c3f9cf75965742