My Icon: move the menu to the frame

[rkabir]

It would be convenient to access the items from anywhere via the frame.

[rkabir]

patch to create xomenu.py, deviceicon

[rkabir]

|TestCase|
Invoke the frame, verify that an XO icon appears.
Hover on the icon, and verify that the Restart, Shutdown, and Settings items appear.
Ensure each item works as expected.

[erikos]

Rkabir, thanks for submitting the patch!

Before I review the technical details - Eben can you comment on the design part?

I guess to be able to access the menu from all the home screen you could make the palette as well accessible from the mesh and groups view. That would not work for the activity view, though.

[tomeu]

+        self._model = SystemModel()

If SystemModel doesn't contain anything relevant, is better to take it out completely. Also, we are trying to keep at a minimum the GObject-based classes because of memory usage.

We are not following MVC strictly at all, just found it to be a nice way to divide responsibilities in some parts of the shell.

+        self.set_size_request(style.zoom(style.GRID_CELL_SIZE * 2), -1)

Do we really need to set a fixed size? set_size_request can cause layout issues in other resolutions.

+    def __popup_cb(self, palette_):
+        pass

Better to take this out if it's not needed.

The patch looks great, will push a reviewed version as I think to remember that Eben agreed on this during the SugarCamp.

Thanks!

[tomeu]

Replying to erikos:

Rkabir, thanks for submitting the patch!

Before I review the technical details - Eben can you comment on the design part?

I guess to be able to access the menu from all the home screen you could make the palette as well accessible from the mesh and groups view. That would not work for the activity view, though.

The palette is attached to a device icon in the frame, so will be accessible from everywhere where the frame is.

[rkabir]

reviewed patch, incorporating tomeu's feedback

[tomeu]

Pushed, thanks for your contribution!

 http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/bd4351a477810b1a8b37c696a62b34fcd600a7e8

[garycmartin]

Testing an XO running joyride 2631, the new palette for your XO frame buddy icon does not include the 'Register' option; not sure if this is intended or not. 'My Settings', 'Logout', 'Restart', 'Shutdown' all worked fine (though I'm not sure if 'Logout' should be showing on XO builds).

[tomeu]

Replying to garycmartin:

Testing an XO running joyride 2631, the new palette for your XO frame buddy icon does not include the 'Register' option; not sure if this is intended or not. 'My Settings', 'Logout', 'Restart', 'Shutdown' all worked fine (though I'm not sure if 'Logout' should be showing on XO builds).

Eben has been working on the XO menus recently and AFAIK that job is finished. Please check a recent build and reopen this if the same issue is still present.