Ticket #1352 (new defect)

Opened 4 years ago

Last modified 3 years ago

Prevent creating parent-less dialogs

Reported by: alsroot Owned by: erikos
Priority: High Milestone: 0.90
Component: sugar-toolkit Version: 0.85.x
Severity: Major Keywords:
Cc: Distribution/OS: Unspecified
Bug Status: Assigned

Description

After moving to metacity we have many issues due to the fact that activity authors do not pass parent while creating ObjectChooser object(for example).

It could be useful for ObjectChooser to make parent argument required(it could be None) for 0.88 and add deprecation warning for 0.86 or do some smart job to autoset parent on shell side.

Also parent argument could be required for sugar.graphics.Window(w/ warning in 0.86) or new Dialog class.

Change History

Changed 4 years ago by alsroot

  • type changed from enhancement to defect

Shanged type to defect since parent-less dialogs are bugs for 0.86.

Changed 4 years ago by alsroot

  • milestone changed from 0.86 to 0.88

Milestone to 0.88, since we are in code freeze

Changed 3 years ago by tomeu

  • owner changed from tomeu to erikos
  • status_field changed from Unconfirmed to Assigned
  • component changed from sugar to sugar-toolkit
  • severity changed from Unspecified to Major
  • milestone changed from 0.88 to 0.90

I agree on this, but would be an API change so needs to be done at the start of a release cycle so activities have time to adapt. do people agree?

Note: See TracTickets for help on using tickets.