Ticket #1335 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

When in fullscreen mode in an activity, frame doesnt pop-up

Reported by: HoboPrimate Owned by: alsroot
Priority: High Milestone: 0.86
Component: sugar-toolkit Version: Git as of bugdate
Severity: Unspecified Keywords: r+
Cc: Distribution/OS: Unspecified
Bug Status: New

Description

Try switching to fullscreen in any activity, like Browse or Terminal. Notice that the hot corners dont work anymore for invoking the frame.

Attachments

sugar-1335.patch Download (4.7 KB) - added by alsroot 4 years ago.

Change History

Changed 4 years ago by garycmartin

  • distribution changed from Ubuntu to Unspecified
  • status_field changed from Unconfirmed to New
  • milestone changed from Unspecified by Release Team to 0.86

Just confirmed this in F11 sugar-jhbuild with ImageViewer and Read as well.

Changed 4 years ago by alsroot

  • owner changed from tomeu to alsroot
  • priority changed from Unspecified by Maintainer to High
  • status changed from new to assigned

Changed 4 years ago by alsroot

  • component changed from sugar to sugar-toolkit

Changed 4 years ago by alsroot

  • keywords r? added
  • owner changed from alsroot to erikos

Changed 4 years ago by alsroot

Changed 4 years ago by alsroot

added code to hide all palettes

Changed 4 years ago by alsroot

The main idea of patch if redefining (un)fullscreen methods and do not set fullscreen wm hint.

Changed 4 years ago by tomeu

  • keywords r+ added; r? removed
  • owner changed from erikos to alsroot

Patch looks great to me, I would just not have those returns in the middle of the method, it makes the reader have to scan the whole method to know which exit points exist:

 	152	        if not self.props.enable_fullscreen_mode: 
 	153	            return 

Changed 4 years ago by alsroot

  • status changed from assigned to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.