add technical details to Journal details view

[sascha_silbe]

This patch series is an attempt at implementing the technical details (file size, file type, file date) info in the Journal details view as demonstrated in  Eben's mockup and thus #517 / #1033.

Open questions (to the designers):
a) what to do if mime_type is not set (currently: displays "Type: ")
b) what to do if filesize is 0 (currently: displays "Size: 0B")

I took the liberty of displaying the MIME type instead of the file extension because it's more appropriate IMO. File extensions are for legacy systems that need to store metadata in the filename and lose some of the information contained in the MIME type.

[sascha_silbe]

Forgot to CC the designers, so asking the questions again:

a) what to do if mime_type is not set (currently: displays "Type: ")
b) what to do if filesize is 0 (currently: displays "Size: 0B")

[garycmartin]

Replying to sascha_silbe:

a) what to do if mime_type is not set (currently: displays "Type: ")

"Kind: <mime_type>" (as per Eben's mock-up and your screen shot look good. If there is no associated mime type I'd suggest showing "Kind: Unknown".

b) what to do if filesize is 0 (currently: displays "Size: 0B")

For "Size: 0B" case I would recommend spelling it out "Size: Zero". Also note the space after the digits as in Eben's mock-up helps readability "Size 215 KB".

Quick sanity check :-) The "Date: 17.08.2009" is shown in the correct locale date format, yes? Is it the file modification date or the file creation date (or does that end up being the same due to the way data-store works)?

[sascha_silbe]

add sugar.util.format_size()

[sascha_silbe]

Sample screenshot

[sascha_silbe]

Replying to garycmartin:

"Kind: <mime_type>" (as per Eben's mock-up and your screen shot look good. If there is no associated mime type I'd suggest showing "Kind: Unknown".

OK, Unknown it is.

b) what to do if filesize is 0 (currently: displays "Size: 0B")

For "Size: 0B" case I would recommend spelling it out "Size: Zero". Also note the space after the digits as in Eben's mock-up helps readability "Size 215 KB".

Spaces added, but spelled it "Empty" instead for zero.

Quick sanity check :-) The "Date: 17.08.2009" is shown in the correct locale date format, yes?

It is. Haven't tried any other locale, but as US format is the default I'm quite sure it works. :)

Is it the file modification date or the file creation date (or does that end up being the same due to the way data-store works)?

There's only one timestamp in the data store.

Thanks for the quick feedback!

[sascha_silbe]

sugar-datastore: add 'filesize' property to metadata returned by API calls

[sascha_silbe]

add technical details to details view in Journal (sugar-datastore change obsolete now)

[tomeu]

Looks great, other than if file_path: should probably check for is None. Please push, thanks!

[tomeu]

Replying to tomeu:

Looks great, other than if file_path: should probably check for is None. Please push, thanks!

Disregard this, have just pushed it.