cannot install new activity version

[sascha_silbe]

After downloading the new version of Read Etexts (a later version was already installed) and clicking "Show in Journal", the following exception occured:

Traceback (most recent call last):
  File "/usr/lib/pymodules/python2.5/dbus/connection.py", line 214, in maybe_handle_message
    self._handler(*args, **kwargs)
  File "/home/sascha.silbe/sugar-jhbuild/install/lib/python2.5/site-packages/jarabe/journal/model.py", line 380, in _datastore_updated_cb
    updated.send(None, tree_id=tree_id, version_id=version_id)
  File "/home/sascha.silbe/sugar-jhbuild/install/lib/python2.5/site-packages/sugar/dispatch/dispatcher.py", line 125, in send
    response = receiver(signal=self, sender=sender, **named)
  File "/home/sascha.silbe/sugar-jhbuild/install/lib/python2.5/site-packages/jarabe/journal/journalactivity.py", line 250, in __model_updated_cb
    self._check_for_bundle(kwargs['tree_id'], kwargs['version_id'])
  File "/home/sascha.silbe/sugar-jhbuild/install/lib/python2.5/site-packages/jarabe/journal/journalactivity.py", line 283, in _check_for_bundle
    registry.install(bundle)
  File "/home/sascha.silbe/sugar-jhbuild/install/lib/python2.5/site-packages/jarabe/model/bundleregistry.py", line 330, in install
    raise AlreadyInstalledException
AlreadyInstalledException

jarabe.model.bundleregistry.BundleRegistry.install() contains the following code:

        if self.get_bundle(bundle.get_bundle_id()):
            raise AlreadyInstalledException

        for installed_bundle in self._bundles:
            if bundle.get_bundle_id() == installed_bundle.get_bundle_id() and \
                    bundle.get_activity_version() == \
                        installed_bundle.get_activity_version():
                raise AlreadyInstalledException
            elif bundle.get_bundle_id() == installed_bundle.get_bundle_id():
                self.uninstall(installed_bundle, force=True)

get_bundle() contains a similar loop like install() but only checks the bundle id, not the activity version. So install() will always fail with AlreadyInstalledException, even when we're trying to install a different version.

After removing the if self.get_bundle... several other errors came up, so can't verify this as the correct fix (yet).

[sascha_silbe]

Fix upgrading of activities

[sascha_silbe]

This patch fixes the tracebacks, but does not prevent activity installation each time a bundle containing an already-installed version is started from Journal. Will file a separate bug about that.

[tomeu]

I guess some stuff will break if we just let several versions of an activity be installed at the same time. AFAIR the idea was to only let users update to later versions until we have proper multiversion support.

Eben, Gary, thoughts on this?

[tomeu]

Please put it back to the review queue once there's consensus on this. Thread:

 http://lists.sugarlabs.org/archive/sugar-devel/2009-August/017801.html

[sascha_silbe]

This is caused by an  incorrect fix for #707. No new behaviour that needs to be discussed, just a simple regression (Daniel Drake confirmed this on sugar-devel).
We should re-check #707, though. It would be very nice for bundle-installed activities to simply override system ones (i.e. scan for user activities first and don't accept duplicates from system-installed activity location). Haven't dug into the code to see how easy it is to implement this, though.

[tomeu]

I'm very confused, just downloaded Calculate 29 from ASLO, it installed fine. Then downloaded Calculate 30 and it updated fine. What's this bug about? Please update the title because "cannot install new activity version" doesn't seem to describe it well enough.

[sascha_silbe]

Has been silently fixed by alsroot on 2009-07-30 in  db6f095.

Only upgrading works now, downgrading fails (AlreadyInstalledException in shell.log, user remains in Journal without any error indication).