Opened 10 years ago

Last modified 6 years ago

#971 accepted enhancement

Global bookmarks in Browse

Reported by: erikos Owned by: humitos
Priority: Normal Milestone:
Component: Browse Version: 0.84.x
Severity: Minor Keywords:
Cc: sdz Distribution/OS: Unspecified
Bug Status: Assigned

Description

Here is the previous discussion about them. Comment from Eben - mixed with offline bookmarks. (needed by SSB as well). Let the discussion start.

I think this ticket could use a little clarification. We've talked about a variety of bookmark types, most notably session, global, and offline bookmarks. This ticket actually describes offline bookmarks, which I think are different from "global" ones, depending on how we define them. Here's what I think we actually want (please clarify or argue these definitions):

Bookmark: A combination of the former definitions for both session and global bookmarks. When created, a thumbnail appears within the bookmarks tray, and is shared among activity participants. It's presence gets stored with the browse session for future reference. In addition, the bookmark gets added to the global bookmark list, though it's not directly exposed anywhere (and it does not get a Journal entry). As an entry in the global bookmark list, it will be available for autocompletion, and will show up in any future implementation of a bookmark/history browser (from within any browse session).

Offline Bookmark: (Better phrasing welcome.) Offline bookmarks create a brand new Journal entry containing the cached page. Optionally, we could add settings to limit the size, compress or scale down images, skip embedded video, etc. But that's all in the details. The general goal is to provide a cached copy of the page which the kids can access later, while offline. Special handling of this form of entry will be required within Browse, so that it's made clear that the page is not live (and, in fact, its actual age is shown), and so that it's not possible to accidentally attempt to click a link and wind up losing the cached data. We can be smart about this. It seems that any offline bookmark should also get added to the list of global bookmarks, accessible from anywhere. A future bookmark/history browser could indicate which bookmarks are offline.

To sum up, there are two types of bookmark, with separate purposes. One creates a session thumbnail and shares it, the other creates a private journal entry and caches it for offline viewing. Both types register the bookmark with the global registry so that a bookmark/history viewer can show them, and so that they are used for autocompletion purposes.

Attachments (1)

keep_offline.patch (7.8 KB) - added by lucian 10 years ago.
'Keep offline' button next to 'Bookmark' button, the resulting Journal objects can be opened with browse. Not tested enough.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 10 years ago by erikos

  • Milestone changed from 0.86 to 0.88
  • Severity changed from Unspecified to Minor

Minor, as we have the autocompletion in the url.

Changed 10 years ago by lucian

'Keep offline' button next to 'Bookmark' button, the resulting Journal objects can be opened with browse. Not tested enough.

comment:2 Changed 10 years ago by lucian

I have a new patch updated to the latest Browse head, but trac's spam filtering (akismet) doesn't let me post it.

comment:3 Changed 10 years ago by sdz

  • Cc sdz added

comment:4 Changed 10 years ago by walter

  • Milestone changed from 0.88 to 0.90

Lucian said he may have time to get back to this soon, but it won't make 0.88

comment:5 Changed 7 years ago by manuq

  • Milestone changed from 0.90 to 0.98

Maybe a nice thing to do for 0.98 .

comment:6 Changed 7 years ago by humitos

  • Priority changed from High to Normal

comment:7 Changed 7 years ago by humitos

  • Owner changed from erikos to humitos
  • Status changed from new to accepted

comment:8 Changed 7 years ago by humitos

  • Milestone changed from 0.98 to 1.0

comment:10 Changed 6 years ago by dnarvaez

  • Milestone 1.0 deleted

Milestone 1.0 deleted

Note: See TracTickets for help on using tickets.