Can not download image when opened in a popup

[erikos]

When the image is opened in a popup (zoom) I can not get a palette to download it.

[erikos]

Most of the zoomed images open now in a new tab. Only the screenshots in activities.sugarlabs.org do not. In firefox one can only get at the image with: "view background image" and then save the image - which is not straightforward neither.

[walter]

As noted, this is painful in all browsers. Maybe 0.90?

[RafaelOrtiz]

Moving to 0.94

[manuq]

Related: #3455 .

[erikos]

Not a regression, moving out.

[humitos]

Setting priority because it's important.

[humitos]

Well, this should be done by looking if the property background-image exists in the element clicked.

For example, the actual code for ​http://activities.sugarlabs.org to show the screenshot images is like:

<div id="lbImage" style="background-image: url(http://activities.sugarlabs.org/en-US/sugar/images/p/5/1235687644); display: block; ">
    <div style="position: relative; width: 700px; height: 525px; ">
        <a id="lbPrevLink" href="#" style="display: none; height: 525px; "></a>
        <a id="lbNextLink" href="#" style="display: none; height: 525px; "></a>
    </div>
</div>

Changing the priority, this is no so important. It's just one specific case.

[humitos]

This is the code we should use to look for background-image property, but we have to go throughout the DOM (from the inside to the top of it) to look that style property.

In the example given in the previous comment, when I click over the image I get the "inner div", so I have to ask for the parent of it to check the background-image property:

>>> element = hit_test.props.inner_node
>>> element.props.style.get_css_text()
'position: relative; width: 700px; height: 525px; '
>>> element.get_parent_element().props.style.get_css_text()
'background-image: url(http://activities.sugarlabs.org/en-US/sugar/images/p/5/1235687644); display: block; '

So, do we want to make that check recursively to check that property? how deep do we want to make it?

[dsd]

The other consideration to keep in mind is that we will lose DOM access in WebKit2. Might be worth looking at if/how epiphany will cope with this, and/or start some discussion on webkit-gtk list.

[manuq]

No other browser is behaving like this. We already make a good job with palettes for images since #4262. I would say won't fix.

[dnarvaez]

Milestone 1.0 deleted