Opened 11 years ago

Closed 10 years ago

Last modified 7 years ago

#934 closed defect (fixed)

If the initiator of a shared activity leaves, she cannot see the session in the Neighborhood

Reported by: bemasc Owned by: sayamindu
Priority: High Milestone:
Component: sugar-presence-service Version: 0.82.x
Severity: Major Keywords: olpc-0.84 r?
Cc: sascha_silbe Distribution/OS: OLPC
Bug Status: Unconfirmed

Description

Suppose a user A initiates a shared session of Chat. B and C then join the session. After some time, A leaves, but the session continues.

If A now looks in the Neighborhood View, A does not see the shared Chat session. In fact, A does not see B or C at all! This prevents A from rejoining the shared session.

This is a pretty serious bug. I don't know if it's still present; I hope someone will test it (it only takes three seconds to test).

Change History (10)

comment:1 Changed 11 years ago by sascha_silbe

  • Cc sascha_silbe added

comment:2 Changed 11 years ago by tomeu

  • Component changed from sugar to sugar-presence-service
  • Milestone changed from Unspecified by Release Team to 0.86
  • Owner changed from tomeu to morgs
  • Priority changed from Unspecified by Maintainer to High
  • Severity changed from Unspecified to Major

This bug is still present, this patch seems to fix it but I'm not sure how correct it is. Help most appreciated.

diff --git a/src/activity.py b/src/activity.py
index 12f3ac2..29ba1a5 100644
--- a/src/activity.py
+++ b/src/activity.py
@@ -1120,6 +1120,8 @@ class Activity(ExportedGObject):
             self._buddy_to_handle[buddy] = handle
         self._add_buddies(added_buddies.itervalues())
 
+        self._claimed_buddies |= set(added_buddies.itervalues())
+
         # we treat all pending members as if they weren't there
         removed = set(removed)
         removed |= set(local_pending)

comment:3 Changed 11 years ago by tomeu

  • Owner changed from morgs to tomeu
  • Status changed from new to assigned

comment:4 Changed 11 years ago by martin.langhoff

http://dev.laptop.org/ticket/9619 has more info and diagnostics. This is affecting 0.84 too :-/

comment:5 Changed 11 years ago by martin.langhoff

Tested Tomeu's patch, works with no side-effects I can spot.

comment:6 Changed 11 years ago by erikos

  • Keywords olpc-0.84 r? added
  • Owner changed from tomeu to sayamindu

Test with two Xo 1.5 and one XO 1.0 as working. I was able to reproduce the bug before and after applying the patch it worked fine. This landed in master already, should be applied to 0.84, too.

comment:7 Changed 10 years ago by tomeu

  • Milestone changed from 0.86 to 0.84

comment:8 Changed 10 years ago by sayamindu

  • Resolution set to fixed
  • Status changed from assigned to closed

Patch applied in sugar-presence-service.

comment:10 Changed 7 years ago by godiard

  • Milestone 0.84 deleted

Milestone 0.84 deleted

Note: See TracTickets for help on using tickets.