Opened 12 years ago

Closed 7 years ago

#863 closed defect (obsolete)

Screen rotation on lid close - Dell Latitude D380

Reported by: martin.langhoff Owned by: tomeu
Priority: Unspecified by Maintainer Milestone: Unspecified
Component: Sugar Version: Unspecified
Severity: Unspecified Keywords:
Cc: Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description

My Latitude D380 records (according to showkey)

227 press
227 release
227 press
227 release

on every lid close / lid open cycle. Sugar has this hardcoded to screen rotate, probably correct on the XO.

Attachments (1)

foo.patch (1.7 KB) - added by biertie 12 years ago.

Download all attachments as: .zip

Change History (9)

Changed 12 years ago by biertie

comment:1 Changed 12 years ago by biertie

a patch for this problem Bernie and I came up with..

comment:2 follow-up: Changed 12 years ago by tomeu

What do you think about moving the rotation key handling to an extension? That way we can keep the hacks out from the shell, which is way safer (because failures in extensions are not propagated to the main loop) and is also nicer from a code organization point of view.

Btw, please see http://wiki.sugarlabs.org/go/Development_Team/CodeReview

comment:3 in reply to: ↑ 2 ; follow-up: Changed 12 years ago by bernie

Replying to tomeu:

What do you think about moving the rotation key handling to an extension? That way we can keep the hacks out from the shell, which is way safer (because failures in extensions are not propagated to the main loop) and is also nicer from a code organization point of view.

Sounds like a good idea, but I lack the expertise to design this solution properly. Are you thinking about an XO specific extension to handle all these little things?

Btw, please see http://wiki.sugarlabs.org/go/Development_Team/CodeReview

Thanks

comment:4 in reply to: ↑ 3 Changed 12 years ago by tomeu

Replying to bernie:

Replying to tomeu:

What do you think about moving the rotation key handling to an extension? That way we can keep the hacks out from the shell, which is way safer (because failures in extensions are not propagated to the main loop) and is also nicer from a code organization point of view.

Sounds like a good idea, but I lack the expertise to design this solution properly.

Don't be so lazy! This is really easy and fun stuff. As an example, this extension will take a screenshot when the user presses the Print key:

http://git.sugarlabs.org/projects/sugar/repos/mainline/blobs/master/extensions/globalkey/screenshot.py

Are you thinking about an XO specific extension to handle all these little things?

Yeah, one for all the special keys on the XO.

Btw, please see http://wiki.sugarlabs.org/go/Development_Team/CodeReview

Thanks

Btw, if you don't put r? in the keywords field, the ticket won't be in the review queue and can get lost for several months.

comment:5 Changed 11 years ago by sdz

  • Milestone soas_fossvt deleted

Milestone soas_fossvt deleted

comment:6 Changed 11 years ago by sascha_silbe

  • Component changed from sugar to SoaS
  • Distribution/OS changed from SoaS to Unspecified
  • Owner changed from tomeu to mchua sdz

Bulk change distribution=SoaS -> component=SoaS

comment:7 Changed 11 years ago by sdz

  • Component changed from SoaS to sugar
  • Milestone set to Unspecified by Release Team
  • Owner changed from mchua sdz to tomeu
  • Status changed from new to assigned

Assigning back to Sugar.

comment:8 Changed 7 years ago by godiard

  • Resolution set to obsolete
  • Status changed from assigned to closed

Probably obsolete. Screen rotation is not managed by Sugar now.

Reopen with more information if needed.

Note: See TracTickets for help on using tickets.