Opened 11 years ago

Closed 11 years ago

Last modified 7 years ago

#843 closed defect (fixed)

Thanks application in pippy has python backtrace invalid int

Reported by: thjc Owned by: mchua sdz
Priority: Unspecified by Maintainer Milestone:
Component: Pippy Version: Unspecified
Severity: Unspecified Keywords:
Cc: jpichon Distribution/OS:
Bug Status: Resolved

Description

From version soas 200905031329

Traceback (most recent call last):

File "/home/liveuser/.sugar/default/org.laptop.Pippy/tmp/pippy_app.py", line 29, in <module>

cols, lines = size()

File "/usr/share/sugar/activities/Pippy.activity/library/pippy/console.py", line 26, in size

cols = int(read_to_delimit('t'))

ValueError: invalid literal for int() with base 10: '21;126'

Attachments (1)

0001-Parse-additional-output-for-xterm-size-reporting-843.patch (1.1 KB) - added by jpichon 11 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 11 years ago by RafaelOrtiz

  • Milestone changed from soas_fossvt to 0.86

changing milestone

comment:2 Changed 11 years ago by jpichon

  • Cc jpichon added

First, thanks to whoever put in the comment with the "xterm magic" url, that really helped. I attached a patch that should fix this issue, tested on the XO with the G1G1 image (0.82?) and on the latest sugar-jhbuild.

I'm not entirely sure why it works though. According to the xterm link, the output of the command sent to /dev/tty should be '8;<rows>;<columns>t' but on the XO it returns '<rows>;<columns>t" (hence the parsing failing on other systems). Any idea?

comment:4 Changed 11 years ago by sascha_silbe

  • Component changed from Pippy to SoaS
  • Distribution/OS changed from SoaS to Unspecified
  • Owner changed from lfaraone to mchua sdz

Bulk change distribution=SoaS -> component=SoaS

comment:5 Changed 11 years ago by jpichon

I've pushed the patch to the Pippy mainline. Since the component in the tracker isn't Pippy anymore, I'm not sure what to do with the status field, please update it as needed or let me know if there are additional steps I can help with for this. Thank you!

comment:6 Changed 11 years ago by sascha_silbe

  • Component changed from SoaS to Pippy
  • Distribution/OS Unspecified deleted

This seems to have been mistakenly changed to Soas; changing back. Please change status as you feel appropriate, jpichon.

comment:7 Changed 11 years ago by jpichon

  • Bug Status changed from Unconfirmed to Resolved

comment:8 Changed 11 years ago by jpichon

  • Resolution set to fixed
  • Status changed from new to closed

comment:9 Changed 7 years ago by dnarvaez

  • Milestone 0.86 deleted

Milestone 0.86 deleted

Note: See TracTickets for help on using tickets.