Opened 10 years ago

Closed 10 years ago

Last modified 6 years ago

#757 closed defect (fixed)

telepathy_room_handle unused and unusable

Reported by: gdesmott Owned by: erikos
Priority: Unspecified by Maintainer Milestone: Unspecified
Component: Sugar Version: Unspecified
Severity: Unspecified Keywords: r+
Cc: Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description

While porting Read to the new tube API, I discovered that Activity._telepathy_room_handle was:
a) never set so was always None
b) potentially usefull for activities (I use it for the port).

The following branch fix these 2 issues by actually setting the value of the room handle and making it public. I think this change is safe, I grepped sugar-jhbuild source and didn't find any code using it (which make sense as it was unusable).

http://git.sugarlabs.org/projects/sugar-toolkit/repos/cassids-sugar-toolkit/trees/room-handle

Attachments (1)

room-handle.patch (1013 bytes) - added by gdesmott 10 years ago.
src/sugar/presence/activity.py | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)

Download all attachments as: .zip

Change History (7)

comment:1 Changed 10 years ago by gdesmott

  • Keywords r? added

Changed 10 years ago by gdesmott

src/sugar/presence/activity.py | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

comment:2 Changed 10 years ago by erikos

  • Keywords r+ added; r? removed

Looks good to me, thanks.

comment:3 Changed 10 years ago by gdesmott

Seems src/sugar/presence/activity.py has been deleted in master. I can't merge my branch.

comment:5 Changed 10 years ago by tomeu

  • Resolution set to fixed
  • Status changed from new to closed

comment:6 Changed 6 years ago by dnarvaez

  • Component changed from sugar-toolkit to Sugar
Note: See TracTickets for help on using tickets.