#757 closed defect (fixed)
telepathy_room_handle unused and unusable
Reported by: | gdesmott | Owned by: | erikos |
---|---|---|---|
Priority: | Unspecified by Maintainer | Milestone: | Unspecified |
Component: | Sugar | Version: | Unspecified |
Severity: | Unspecified | Keywords: | r+ |
Cc: | Distribution/OS: | Unspecified | |
Bug Status: | Unconfirmed |
Description
While porting Read to the new tube API, I discovered that Activity._telepathy_room_handle was:
a) never set so was always None
b) potentially usefull for activities (I use it for the port).
The following branch fix these 2 issues by actually setting the value of the room handle and making it public. I think this change is safe, I grepped sugar-jhbuild source and didn't find any code using it (which make sense as it was unusable).
http://git.sugarlabs.org/projects/sugar-toolkit/repos/cassids-sugar-toolkit/trees/room-handle
Attachments (1)
Change History (7)
comment:1 Changed 15 years ago by gdesmott
- Keywords r? added
comment:3 Changed 15 years ago by gdesmott
Seems src/sugar/presence/activity.py has been deleted in master. I can't merge my branch.
comment:4 Changed 15 years ago by tomeu
sugar-toolkit was moved to its own module:
comment:5 Changed 14 years ago by tomeu
- Resolution set to fixed
- Status changed from new to closed
comment:6 Changed 10 years ago by dnarvaez
- Component changed from sugar-toolkit to Sugar
Note: See
TracTickets for help on using
tickets.