Palette needs a minimum size

[erikos]

And therefore has problems when the text gets larger (translated text). Easily seen with -s 72 and German. Before the limiting fix from yesterday the text got cropped. Now it gets ellipsized without need.

diff --git a/extensions/deviceicon/speaker.py b/extensions/deviceicon/speaker.py
index d8e7a2b..3a54464 100644
--- a/extensions/deviceicon/speaker.py
+++ b/extensions/deviceicon/speaker.py
@@ -93,8 +93,6 @@ class SpeakerPalette(Palette):
 
         self._model = model
 
-        self.set_size_request(style.zoom(style.GRID_CELL_SIZE * 4), -1)
-
         vbox = gtk.VBox()
         self.set_content(vbox)
         vbox.show()

[erikos]

As discussed with Martin on irc, his intention was a minimum size of the palette as described in the HIG (correct eben?). Now the slider is a bit small. I guess this has to be handled in the palette class directly as we otherwise will see issues like this one.

As a fix for 0.84 I will remove the size_request.

[erikos]

Fixed with: ​http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/edcda3558e6664919ddba5b788104e0d9508cf7e

Moving to 0.86 for a minimum size.

[tomeu]

Looks like this will miss 0.88 :(

[walter]

This didn't ever seem to get into the review queue... probably too late for 0.88, but leaving that milestone for the time being.

[tomeu]

Replying to walter:

This didn't ever seem to get into the review queue... probably too late for 0.88, but leaving that milestone for the time being.

That particular patch did got in, but it's only for a specific case, not for the general case.

[dnarvaez]

I'm unconvinced we can do this in the general case. And I guess the fact that it has been here for 3 years says something.