Opened 10 years ago

Closed 7 years ago

Last modified 6 years ago

#714 closed enhancement (fixed)

filter for audio

Reported by: erikos Owned by: kushal
Priority: Unspecified by Maintainer Milestone:
Component: Jukebox Version: 0.84.x
Severity: Major Keywords:
Cc: cjl Distribution/OS: Unspecified
Bug Status: New

Description

chooser = ObjectChooser(_('Choose image'), self._parent,
                                gtk.DIALOG_MODAL | gtk.DIALOG_DESTROY_WITH_PARENT,
                                what_filter=mime.GENERIC_TYPE_AUDIO)

Change History (8)

comment:1 Changed 10 years ago by kushal

If I do this , then it is not picking the different playlist files, is this the correct behaviour ?

comment:2 Changed 10 years ago by tomeu

I guess we need to tell Sugar that .pls files are audio files, see GENERIC_TYPE_AUDIO in sugar-base/src/sugar/mime.py.

comment:3 Changed 8 years ago by RafaelOrtiz

this .pls mimetype is in sugar by audio/x-scpls'
http://git.sugarlabs.org/sugar-base/mainline/blobs/master/src/sugar/mime.py

	
	
    'id': GENERIC_TYPE_AUDIO,
	
    'name': _('Audio'),
	
    'icon': 'audio-x-generic',
	
    'types': [
	
        'audio/ogg', 'audio/x-wav', 'audio/wav', 'audio/x-vorbis+ogg',
	
        'audio/x-mpegurl', 'audio/mpegurl', 'audio/mpeg', 'audio/x-scpls'],

comment:4 follow-up: Changed 8 years ago by RafaelOrtiz

jukebox has the corrected chooser in

248 chooser = ObjectChooser(_('Choose document'), self,
249 gtk.DIALOG_MODAL |
250 gtk.DIALOG_DESTROY_WITH_PARENT,
251 what_filter=mime.GENERIC_TYPE_AUDIO)

I'd would only change 'Choose document' for 'Choose media'

comment:5 in reply to: ↑ 4 Changed 8 years ago by godiard

  • Cc cjl added

Replying to RafaelOrtiz:

.....

I'd would only change 'Choose document' for 'Choose media'

I don't know, will break all the translations and "media" is not very clear for a child. CC to cjl to see if he has any idea about what do here.

comment:6 Changed 8 years ago by cjl

Change any UI string that is needed for clarity. Then regenerate and commit the POT. We'll update the POT on Pootle from VCS and localizers will correct the one string. Not a big deal.

comment:7 Changed 7 years ago by godiard

  • Resolution set to fixed
  • Status changed from new to closed

Changing the title in the ObjectChooser is deprecated for a long time.

This ticket can be closed.

comment:8 Changed 6 years ago by dnarvaez

  • Milestone 0.86 deleted

Milestone 0.86 deleted

Note: See TracTickets for help on using tickets.