icon frame does overlap (favorites view)

[erikos]

• i have 12 icons in the circle
• the frame when hovering over 10 goes over the icon of 11
• (is dependent a bit on the icon of 11)
• can be seen as well on 1,2 o'clock (or 4,5 - 7,8)

[erikos]

one first guess by tomeu was a rounding issue:

diff --git a/src/jarabe/desktop/favoriteslayout.py b/src/jarabe/desktop/favoriteslayout.py
index 506446f..4228553 100644
--- a/src/jarabe/desktop/favoriteslayout.py
+++ b/src/jarabe/desktop/favoriteslayout.py
@@ -242,10 +242,10 @@ class RingLayout(FavoritesLayout):
     def _calculate_position(self, radius, icon_size, index, children_count,
                             sin=math.sin, cos=math.cos):
         width, height = self.box.get_allocation()
-        angle = index * (2 * math.pi / children_count) - math.pi / 2
-        x = radius * cos(angle) + (width - icon_size) / 2
+        angle = index * (2 * math.pi / children_count) - math.pi / 2.0
+        x = radius * cos(angle) + (width - icon_size) / 2.0
         y = radius * sin(angle) + (height - icon_size -
-                                   (style.GRID_CELL_SIZE/2) ) / 2
+                                   (style.GRID_CELL_SIZE / 2.0) ) / 2.0
         return x, y
 
     def _get_children_in_ring(self): 

[erikos]

​http://dev.sugarlabs.org/ticket/624#comment:9 is of interest here.

[tomeu]

doesn't seem like a blocker to me

[dnarvaez]

Milestone 0.86 deleted