Opened 10 years ago

Closed 6 years ago

Last modified 6 years ago

#636 closed defect (obsolete)

icon frame does overlap (favorites view)

Reported by: erikos Owned by: tomeu
Priority: Unspecified by Maintainer Milestone:
Component: Sugar Version: 0.84.x
Severity: Critical Keywords:
Cc: sascha_silbe Distribution/OS: Unspecified
Bug Status: New

Description

  • i have 12 icons in the circle
  • the frame when hovering over 10 goes over the icon of 11
  • (is dependent a bit on the icon of 11)
  • can be seen as well on 1,2 o'clock (or 4,5 - 7,8)

Change History (8)

comment:1 Changed 10 years ago by erikos

one first guess by tomeu was a rounding issue:

diff --git a/src/jarabe/desktop/favoriteslayout.py b/src/jarabe/desktop/favoriteslayout.py
index 506446f..4228553 100644
--- a/src/jarabe/desktop/favoriteslayout.py
+++ b/src/jarabe/desktop/favoriteslayout.py
@@ -242,10 +242,10 @@ class RingLayout(FavoritesLayout):
     def _calculate_position(self, radius, icon_size, index, children_count,
                             sin=math.sin, cos=math.cos):
         width, height = self.box.get_allocation()
-        angle = index * (2 * math.pi / children_count) - math.pi / 2
-        x = radius * cos(angle) + (width - icon_size) / 2
+        angle = index * (2 * math.pi / children_count) - math.pi / 2.0
+        x = radius * cos(angle) + (width - icon_size) / 2.0
         y = radius * sin(angle) + (height - icon_size -
-                                   (style.GRID_CELL_SIZE/2) ) / 2
+                                   (style.GRID_CELL_SIZE / 2.0) ) / 2.0
         return x, y
 
     def _get_children_in_ring(self): 

comment:2 Changed 10 years ago by sascha_silbe

  • Cc sascha_silbe added

comment:3 Changed 10 years ago by tomeu

  • Severity changed from Critical to Blocker

comment:5 Changed 10 years ago by erikos

  • Milestone changed from 0.84 to 0.86

comment:6 Changed 10 years ago by tomeu

  • Severity changed from Blocker to Critical

doesn't seem like a blocker to me

comment:7 Changed 6 years ago by walter

  • Resolution set to obsolete
  • Status changed from new to closed

comment:8 Changed 6 years ago by dnarvaez

  • Milestone 0.86 deleted

Milestone 0.86 deleted

Note: See TracTickets for help on using tickets.