Opened 12 years ago

Last modified 11 years ago

#569 new defect

XOIRC error in irc_script.py

Reported by: walter Owned by: mchua sdz
Priority: Unspecified by Maintainer Milestone: Unspecified
Component: Irc Version: 0.84.x
Severity: Minor Keywords:
Cc: Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description

When testing the latest SoaS image, I noticed some error messages in the log for XOIRC.

1.

Traceback (most recent call last):

2.

File "/home/liveuser/Activities/IRC.activity/purk/events.py", line 44, in trigger

3.

f_ref(e_data)

4.

File "/home/liveuser/Activities/IRC.activity/purk/scripts/theme.py", line 309, in onNick

5.

window = windows.get(windows.ChannelWindow, e.network, channame)

6.

TypeError: get() takes exactly 4 arguments (3 given)

7.

Traceback (most recent call last):

8.

File "/home/liveuser/Activities/IRC.activity/purk/events.py", line 44, in trigger

9.

f_ref(e_data)

10.

File "/home/liveuser/Activities/IRC.activity/purk/scripts/irc_script.py", line 309, in setdownNick

11.

window = windows.get(windows.QueryWindow, e.network, e.source)

12.

TypeError: get() takes exactly 4 arguments (3 given)

Tomeu wrote the following patch which seems to fix things.

1.

diff --git a/purk/scripts/irc_script.py b/purk/scripts/irc_script.py

2.

index 6e38005..a993d2c 100644

3.

--- a/purk/scripts/irc_script.py

4.

+++ b/purk/scripts/irc_script.py

5.

@@ -306,7 +306,7 @@ def onCommandNick(e):

6.


7.

def setdownNick(e):

8.

if e.source != e.network.me:

9.

  • window = windows.get(windows.QueryWindow, e.network, e.source)

10.

+ window = windows.get(windows.QueryWindow, e.network, e.source, core)

11.

if window:

12.

window.id = e.target

Change History (3)

comment:1 Changed 12 years ago by tomeu

nicer patch:

diff --git a/purk/scripts/irc_script.py b/purk/scripts/irc_script.py
index 6e38005..a993d2c 100644
--- a/purk/scripts/irc_script.py
+++ b/purk/scripts/irc_script.py
@@ -306,7 +306,7 @@ def onCommandNick(e):
 
 def setdownNick(e):
     if e.source != e.network.me:
-        window = windows.get(windows.QueryWindow, e.network, e.source)
+        window = windows.get(windows.QueryWindow, e.network, e.source, core)
         if window:
             window.id = e.target


comment:2 Changed 11 years ago by sascha_silbe

  • Component changed from Irc to SoaS
  • Distribution/OS changed from SoaS to Unspecified
  • Owner changed from mchua to mchua sdz

Bulk change distribution=SoaS -> component=SoaS

comment:3 Changed 11 years ago by sdz

  • Component changed from SoaS to Irc

This is a IRC issue that got accidentally assigned to SoaS during an auto-tag. Reassigning - sorry for the confusion.

Note: See TracTickets for help on using tickets.