Opened 12 years ago

Closed 12 years ago

#547 closed defect (fixed)

Resume by default should "open with", not "open"

Reported by: homunq Owned by: tomeu
Priority: Unspecified by Maintainer Milestone: Unspecified
Component: Sugar Version: Unspecified
Severity: Unspecified Keywords: r+
Cc: Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description

[Fri Mar 13 2009] [22:05:57] <homunq> ActivityIcon is wrong (it resumes the instance from journal with no activity_id, which if it is an activity bundle launches it)

[Fri Mar 13 2009] [22:06:20] <homunq> but there are two ways to fix it - s/)/,bundle_id)/ or s/journal.misc.resume/activityfactory.create_with_object_id/. (obviously, not literally, just idea)

[Fri Mar 13 2009] [22:07:56] <homunq> any reason I should choose one or the other?

[Fri Mar 13 2009] [22:08:20] <homunq> method 1 smaller change, method 2 more consistent, AFAICT result same.

Attachments (1)

0001-bug-547-resume-by-default-uses-open-with-not-just.patch (1.0 KB) - added by homunq 12 years ago.
patch to fix

Download all attachments as: .zip

Change History (4)

Changed 12 years ago by homunq

patch to fix

comment:1 Changed 12 years ago by homunq

  • Keywords r? added

|TestCase|

Get Develop activity from activities.sugarlabs.org . Use it to open another activity - say, Log. Make an edit (to NEWS or something) and close. Click on it again. Result before fix: you run the other activity. Result after fix: you reopen it for editing.

comment:2 Changed 12 years ago by homunq

modules affected: sugar (patch is 1 line)

comment:3 Changed 12 years ago by tomeu

  • Keywords r+ added; r? removed
  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.