Mime type mess with files downloaded with Browse

[sayamindu]

Files which are normally zip files (eg: Open Document files, Epub files, etc) seem to have the extension set to application/x-zip in the datastore. Steps to reproduce

1. Open Browse and navigate to ​http://feedbooks.com/book/102

2. Download the epub file linked from that page

3. Try to open the file from the journal (you can have a mock activity which has the mimetype for application/epub+zip registered)

4. View the log for Journal: it contains a line which says:

WARNING root: No activity can open this object, application/x-zip.

This normally occurs when the extension of the file is truncated, which means that there is no way to distinguish the file from a normal zip file.

I have seen this occur on Sucrose 0.82, on XO OS build 767

[sayamindu]

As per discussion on IRC, I also included a mimetype.xml file in my activity. It did not seem to fix the problem

[sayamindu]

This hack seems to solve the issue.

[tomeu]

Would this patch help with zip-based file types? I would prefer not discarding always the mime type sent by the server because many webapps would break that way.

diff --git a/downloadmanager.py b/downloadmanager.py
index e41d06f..69d1c8a 100644
--- a/downloadmanager.py
+++ b/downloadmanager.py
@@ -180,7 +180,8 @@ class Download:
             self.dl_jobject.metadata['progress'] = '100'
             self.dl_jobject.file_path = self._target_file.path
 
-            if self._mime_type == 'application/octet-stream':
+            if self._mime_type in ['application/octet-stream',
+                                   'application/x-zip']:
                 sniffed_mime_type = mime.get_for_file(self._target_file.path)
                 self.dl_jobject.metadata['mime_type'] = sniffed_mime_type
 

[tomeu]

Also, you may want to add an icon and a parent mime type. From the odt file:

  <sub-class-of type="application/zip"/>
  <generic-icon name="x-office-document"/>

[tomeu]

Fixed by ​http://git.sugarlabs.org/projects/browse/repos/mainline/commits/ef1d638d

[godiard]

Milestone 0.84 deleted