Opened 3 years ago

Last modified 22 months ago

#4940 new defect

Journal entries name can be renamed to blank

Reported by: Abrahm Owned by:
Priority: Unspecified by Maintainer Milestone: Unspecified
Component: Sugar Version: Unspecified
Severity: Unspecified Keywords: patch added
Cc: SAMdroid Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description

Steps to produce:

  1. Click on the name an entry to rename
  2. Erase the name
  3. Press enter

An entry without any name!

Attachments (1)

blank_names.png (14.4 KB) - added by Abrahm 3 years ago.
Attached file: Screen shot of Journal activity having entries without name

Download all attachments as: .zip

Change History (10)

Changed 3 years ago by Abrahm

Attached file: Screen shot of Journal activity having entries without name

comment:1 Changed 3 years ago by Abrahm

comment:2 Changed 3 years ago by Abrahm

  • Keywords patch added added

comment:3 Changed 3 years ago by SAMdroid

Tested on master, I can reproduce this. It seems like a bad thing that users will accidentally do, and then not know that they can change it back.

comment:4 Changed 3 years ago by Abrahm

Yes @SAMdroid ! I have submitted the patch to resolve this. Link to PR https://github.com/sugarlabs/sugar/pull/655

comment:5 Changed 3 years ago by Abrahm

Yes @SAMdroid ! I have submitted the patch to resolve this. Link to PR https://github.com/sugarlabs/sugar/pull/655

comment:6 Changed 2 years ago by quozl

In 0.108 rename to blank or empty is possible for the journal list view, the detail view, and the activity title.

In 0.110 rename to blank or empty is possible for the detail view, and the activity title.

A partial solution landed. The user experience is inconsistent. As a result, the learner may fail to discover the rename feature. Recovering from an accidental activity title change is more difficult, because the action requires the detail view.

Looking at the history;

My opinion is the bug seems like censorship; why can't the learner use a blank or empty name for a journal object? It is an unnecessary restriction on expression. Why can't Sugar just do what it is told? The learner can always discover how to rename again.

So I'd like to see the first patch reverted, and instead patches made to the Help activity explaining the rename to blank feature.

I've reverted the patch in my OLPC branch.

comment:7 Changed 2 years ago by jouravla

This ticket is still open. The suggested patch ​(https://github.com/sugarlabs/sugar/pull/655) seems to have been merged into the master, but the issue persists.

comment:8 Changed 2 years ago by quozl

I'm still unwilling to have this "fixed"; and while 655 is merged, 663 is not, so the restriction is inconsistent. I've still got 655 reverted in the OLPC branch; blank and empty journal entries are allowed.

comment:9 Changed 22 months ago by quozl

Note: See TracTickets for help on using tickets.