Opened 3 years ago

Last modified 22 months ago

#4904 new defect

Journal star does not give immediate feedback

Reported by: quozl Owned by:
Priority: High Milestone: Unspecified
Component: Sugar Version: Git as of bugdate
Severity: Major Keywords:
Cc: Distribution/OS: OLPC
Bug Status: New

Description

Show the journal. Click on a star icon.

Expected result: the star icon should toggle.

Observed result: nothing changes until the journal is scrolled or refreshed (f5).

Seen with Sugar 0.107.0 on Fedora 18.

May relate to #4852 fixes.

Change History (7)

comment:1 Changed 3 years ago by Abrahm

Another related issue https://bugs.sugarlabs.org/ticket/4944.

This issue is about star not toggling when the window/view has only one entry.

comment:2 Changed 3 years ago by SAMdroid

I can *not* reproduce this issue on Fc24 rawhide. Didn't this get addressed by [1]? @Quozl could you test?

@Abrahm However I can reproduce the #4944 issue. Maybe they are not related?

[1] https://github.com/sugarlabs/sugar/pull/520

comment:3 Changed 3 years ago by Abrahm

@SAMdroid But the star wont toggle immediately on the click. This happens when the list of entries for the display are less.
As per my observation if all the entries can be visible in single window (ie no need of scroll-bar , in my case 11 entries) the star wont toggle immediately.It toggles only when you hover the mouse on other star or icon (Or something hover away from the star pressed and then bring back the cursor over the same row!)

This is weired!

comment:4 Changed 3 years ago by Abrahm

It seems [1] has made the star to toggle immediately for large lists but not for the small list of entries. The issue is not yet fixed!

[1] https://github.com/sugarlabs/sugar/pull/520

comment:5 Changed 2 years ago by quozl

Still occurs with Sugar 0.110.0 on Fedora 18 and Ubuntu 16.04.1.

Workaround is to switch views using the icons at the bottom of the screen; e.g. between Documents and Journal. After that the star icon has changed.

comment:6 Changed 2 years ago by quozl

Only the first row of the journal is affected.

A working hack is to call Gtk.TreeView.queue_draw_area a second time with the same arguments via GLib.idle_add if the rectangle to redraw has a Y value of zero. It is not yet known why this is needed.

        def redraw():
            view.queue_draw_area(rect.x, rect.y, rect.width, rect.height)
            return False
        redraw()
        if rect.y == 0:
            GLib.idle_add(redraw)  # nuts, why is it so?

This hack may indicate the nature of the problem somehow.

comment:7 Changed 22 months ago by quozl

Confirmed again with Sugar 0.110 on Fedora and Ubuntu.

Note: See TracTickets for help on using tickets.