Separator height has regressed

[ignacio]

Fedora 24 (rawhide), Gtk 3.18

The separators on toolbars (and I think in submenus too) have regressed.

They height is 100% of the main widget.

How to see it:
1) Open read activity
2) Click on viewtoolbar
3) See the separators.

[ignacio]

A small patch can be:

diff --git a/gtk3/theme/gtk-widgets.css.em b/gtk3/theme/gtk-widgets.css.em
index 9b636c8..35d0a1d 100644
--- a/gtk3/theme/gtk-widgets.css.em
+++ b/gtk3/theme/gtk-widgets.css.em
@@ -73,7 +73,7 @@ disabled_opacity = 0.5
     /* 0.05 works good for both the sugar and sugar-xo themes */
     -GtkWidget-cursor-aspect-ratio: 0.05;
 
-    -GtkWidget-wide-separators: true;
+    -GtkWidget-wide-separators: false;
     -GtkWidget-separator-height: $thickness;
     -GtkWidget-separator-width: $thickness;
 
@@ -551,6 +551,7 @@ SugarPaletteWindowWidget GtkProgressBar.trough {
 /* Separators */
 
 .separator {
+    color: @button_grey;
     border-style: solid;
     border-color: @button_grey;
     border-width: $(thickness)px;

But the problem is that the width will not be the same as usually.
When you test the patch in XO, with older Gtk version, the separators are too small.

[SAMdroid]

Can not reproduce on fedora 24 rawhide with gtk 3.18.1.

[ignacio]

Yep, you did.

Here is how it should look (screenshot from XO)

[ignacio]

Proposed patch: ​https://github.com/sugarlabs/sugar-artwork/pull/79

[SAMdroid]

I think the idea was that I liked the new look and that it was hard to correctly fix.

Marking as WONTFIX.