menu pops up in wrong place sometimes

[quozl]

sometimes a palette will appear in the wrong place on screen. this seems to happen especially when the system is under load.

however, it can be reproduced carefully on a system with no load by forging mouse actions with strict timing.

sugar should behave correctly even in this scenario, and fixing it to work correctly will also fix the problems when under load.

restating in standard bug report format:

problem: palette pops up in wrong place sometimes

reproducer: right click on the centre icon, then between 10 and 40 milliseconds later move the mouse a long way from the icon.

expected result: palette should be drawn where the click was captured.

observed result: palette is drawn in the new mouse location.

occurs reliably with times of up to 100 milliseconds, then becomes less reliable.

automated method of reproducing;

prepare the system:

sudo yum install xdotool
service sshd start
chkconfig sshd on
passwd #   or other method to enable remote SSH into system

position sugar at the home view with no palette popped up.
reproduce the problem:

ssh host 'DISPLAY=:0 xdotool mousemove 600 450 click 3 sleep 0.04 mousemove 30 30'

observe the location of the palette.

[quozl]

screenshot showing menu in wrong place

[SAMdroid]

s/menu/palette/g

Sugar gets the cursor position at ​https://github.com/sugarlabs/sugar-toolkit-gtk3/blob/master/src/sugar3/graphics/palettewindow.py#L852

To fix this bug, we need to move this to closer to the click

[quozl]

agreed. the button down event for the click has coordinates of mouse captured by X server at the time of the click.

[SAMdroid]

Another way to reproduce is using a touchscreen and a mouse.

1. Right click icon
2. Press touch screen very quickly after

[SAMdroid]

Patch ​https://github.com/sugarlabs/sugar-toolkit-gtk3/pull/259

[quozl]

New patch ​https://github.com/sugarlabs/sugar-toolkit-gtk3/pull/265

[quozl]

Was merged as 739dacbd01c84d4069db4d9b876cccf4c49a9cc2, closing, seems fixed in 0.107.2