Opened 9 years ago

Closed 7 years ago

#4885 closed defect (fixed)

WebKit2: Lack of history api blocks porting

Reported by: SAMdroid Owned by:
Priority: Normal Milestone: Unspecified
Component: Browse Version: Unspecified
Severity: Blocker Keywords:
Cc: quozl Distribution/OS: Unspecified
Bug Status: New

Description

The WebKit2 port of browse is blocked by the removal of history apis.

Offending code: ​https://github.com/sugarlabs/browse-activity/blob/master/browser.py#L612-L617

Upstream bug: ​https://bugs.webkit.org/show_bug.cgi?id=147525

Change History (4)

comment:1 Changed 9 years ago by quozl

  • Cc quozl added

Next step would seem to be to to ​bring the session save restore into gtk bindings. Is there a ticket for that?

comment:2 Changed 9 years ago by SAMdroid

Turns out DNarvaez logged a ticket for this api 2 years ago :)

​https://bugs.webkit.org/show_bug.cgi?id=115600

comment:3 Changed 9 years ago by SAMdroid

Underlying bug is due to the lack of a LegacySessionStateCoding, patches: ​https://bugs.webkit.org/show_bug.cgi?id=84960

I just got a code review. The maintainer sent a patch themselves, which is awesome! Hopefully this feature will be merged by the next WebKitGtk+ release!

comment:4 Changed 7 years ago by quozl

  • Resolution set to fixed
  • Status changed from new to closed

Was merged.

Note: See TracTickets for help on using tickets.