Opened 8 years ago

Closed 8 years ago

#4865 closed defect (fixed)

control panel: changes on jabber server config are not saved

Reported by: godiard Owned by:
Priority: Unspecified by Maintainer Milestone: Unspecified
Component: Sugar Version: Unspecified
Severity: Unspecified Keywords:
Cc: Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description

Reported by tkkang and confirmed by quozl

Present on 0.105

Change History (4)

comment:1 Changed 8 years ago by godiard

The error happened at random, I could reproduce, but not every time.

comment:2 Changed 8 years ago by quozl

It reproduced for me every time if I was careful not to press the tab key or click in any other field before clicking on the tick (commit) icon.

comment:4 Changed 8 years ago by Gonzalo Odiard

  • Resolution set to fixed
  • Status changed from new to closed

Simplify logic to apply jabber server config changes - Fixes #4865

There multiples fixes here:

  • On apply_jabber method, don't compare with the model._get_jabber

function, but with the result of executing the function.

  • jabber set/get method don't throw ReadError exceptions,

then do not have sense cathit here, or have a jabber_alert.
Remove all the logic. Probably copied from radio_toggled_cb,
but not needed here.

  • Make apply_jabber private, is a internal implementation.

Changeset: ae24236e6e0ea65f20361fb96050a8cfd4bb162a

Note: See TracTickets for help on using tickets.