about me asks for restart but does not restart

[quozl]

Sugar 0.105.2 on commodity hardware.

Reproducer: with no Jabber server configured, open My Settings, About Me, change nick, press TAB, click tick icon, agree to restart.

Expected result: restart, no errors in log.

Observed result: does not restart, errors in log corresponding to the press of TAB key;

Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/dbus/connection.py", line 604, in msg_reply_handler
    reply_handler(*message.get_args_list(**get_args_opts))
  File "/usr/lib/python2.7/dist-packages/jarabe/model/neighborhood.py", line 338, in __get_self_handle_cb
    connection = self._connection[CONNECTION_INTERFACE_ALIASING]
  File "/usr/lib/python2.7/dist-packages/telepathy/client/interfacefactory.py", line 74, in __getitem__
    raise KeyError(name)
KeyError: 'org.freedesktop.Telepathy.Connection.Interface.Aliasing'
1435134844.412208 ERROR dbus.connection: Exception in handler for D-Bus signal:
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/dbus/connection.py", line 230, in maybe_handle_message
    self._handler(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/jarabe/model/neighborhood.py", line 592, in __members_changed_cb
    self._add_buddy_handles(added)
  File "/usr/lib/python2.7/dist-packages/jarabe/model/neighborhood.py", line 604, in _add_buddy_handles
    self._connection[CONNECTION_INTERFACE_CONTACTS].GetContactAttributes(
  File "/usr/lib/python2.7/dist-packages/telepathy/client/interfacefactory.py", line 74, in __getitem__
    raise KeyError(name)
KeyError: 'org.freedesktop.Telepathy.Connection.Interface.Contacts'

Reproduces on a second system.

Complete shell log: ​http://dev.laptop.org/~quozl/z/1Z7gCP.txt

[quozl]

Also blocks logout, shutdown, and restart menu options.

[godiard]

Tried in two systems but couldn't reproduce.

Question: In the session where you found his, tested some activity that crashed?

If not, maybe you can add log to jarabe/model/session.py in the method shutdown_completed().

[quozl]

The immediately prior tests were of ad-hoc networking, and no activities crashed.

[ignacio]

I can reproduce on Sugar 0.105.1 testing image in a XO-4
​http://wiki.sugarlabs.org/go/0.106/Testing

I will try to fix it

[ignacio]

Replying to ignacio:
It's weird. Sometimes it works, and sometimes it doesn't

I can reproduce on Sugar 0.105.1 testing image in a XO-4
​http://wiki.sugarlabs.org/go/0.106/Testing

I will try to fix it

[quozl]

​https://dev.laptop.org/ticket/12813 updated with test findings and analysis.

the problem can be reproduced easily, and there have been several reports that are likely to have been the same underlying root cause.

the root cause is that sugar does not handle the situation where an activity or application has not responded to the session manager save yourself message.

contributing causes are opening many activities, activities or applications that are in a CPU loop or blocked on a network event, and very slow hardware.

[quozl]

it is easily fixed in session.py by abandoning the wait for activities or applications that have not responded. question for discussion; how long should it wait before giving up like this? to me, 15 seconds is adequate. other opinions?

[SAMdroid]

15 sounds very long, but really anything is better than not restarting!

On mobile devices, the kenel will force a reboot after 7 secs, just for comparison. Tested on nexus 9, nexus 4.