Gears-6 flashing colours on resume from journal

[quozl]

Reproducer:

• install Gears-6
• run, and make a model, then stop,
• resume from journal.

Expected result:

• normal operation, colours as before, ability to stop.

Observed result:

• colours of gears flash continually, buttons do not respond, stop does not work, have to kill the process.

​http://lists.sugarlabs.org/archive/sugar-devel/2015-May/050329.html

[tch]

This particular bug was fixed in the upstream repository [1], but there hasn't been a new release.

There is another problem though, even when this bug is fixed, another upstream patch broke datastore integration, so we can't release it as it is. I am looking at it now.

Refs:

1. ​https://github.com/manuq/gears-activity/commit/3f5bbea545335fbd2ba1fb1b98f505761da1063d

[tch]

Update: as suggested by Gonzalo, reverting this [1] patch solves the second problem with datastore integration, but the diff is too big to tell what exactly make the breakage.

Please note that this bug affects also Sugar running in Fedora 21.

CC'ing Lionel.

Refs:

1. ​https://github.com/manuq/gears-activity/commit/014c49b8695a4596015f88a5f4a3c4474ce40154

[llaske]

Already fixed in source code here: ​https://github.com/manuq/gears-activity/commit/3f5bbea545335fbd2ba1fb1b98f505761da1063d
Commited here ​https://github.com/manuq/gears-activity/commit/29343ac1a43b8005984a3d5d8fa2acdd0966adea
BTW I'm not sure that this fixed was included in a Gears release.

[tch]

Replying to llaske:

Already fixed in source code here: ​https://github.com/manuq/gears-activity/commit/3f5bbea545335fbd2ba1fb1b98f505761da1063d
Commited here ​https://github.com/manuq/gears-activity/commit/29343ac1a43b8005984a3d5d8fa2acdd0966adea
BTW I'm not sure that this fixed was included in a Gears release.

Thanks for the reply Lionel, I already mentioned it, but another patch you added (the one I mentioned above) seems to break integration with the datastore, any idea why?

[llaske]

Hmmm. Had a look on it and I've reproduced the issue.
I guessed it was related to an issue on my Sugar-Web version (that is compatible with both Sugar and Sugarizer) but it works for others activities.
I'm going to have a deep look on the issue.

[llaske]

I've found where is the issue.
It's related to the writing into datastore.
Gears activity write into the datastore when there is a click on the stop button [1].
But the stop button generate also the closing of the activity [2].
It seems that the writing into the datastore had no time to do its job before the closing. So nothing is saved into the datastore.

In my pull request I've updated the Sugar-Web version to the last version and in the previous version embedded into the application, there was a wait on data stored [3].

There is no issue into Sugarizer because of course closing of activity is handle by the JavaScript engine too, not by Python.

[1] ​https://github.com/manuq/gears-activity/blob/master/js/activity.js#L15
[2] ​https://github.com/sugarlabs/sugar-web/blob/master/activity/activity.js#L63
[3] ​https://github.com/manuq/gears-activity/commit/014c49b8695a4596015f88a5f4a3c4474ce40154?diff=split#diff-3fc140d0709ed6a81674da52dcf536ecL24

[llaske]

Finally find a way to fix the issue on datastore integration.
I've introduced a delay before close using a not needed datastore save [1].
I've send a pull request.

[1] ​https://github.com/manuq/gears-activity/pull/2/files#diff-3fc140d0709ed6a81674da52dcf536ecR41