Opened 8 years ago

Closed 8 years ago

#4790 closed defect (fixed)

ImageViewer: change colors on Fedora 20

Reported by: godiard Owned by:
Priority: Unspecified by Maintainer Milestone: Unspecified
Component: Imageviewer Version: Unspecified
Severity: Unspecified Keywords: F20
Cc: quozl Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description

In Fedora 20 images, the image colors are wrong.

A patch is available https://github.com/godiard/imageviewer-activity/pull/1 but in theory cairo.create_similar should work and provide better performance.

The issue is only visible in Fedora 20 images on arm, works ok on i686.

In Fedora 18 worked without issues.

Attachments (4)

payaso.png (50.2 KB) - added by godiard 8 years ago.
Original image
bad_colors_using_create_similar.png (22.9 KB) - added by godiard 8 years ago.
How is displayed in the ImageViewer activity
xdpyinfo_f18.log (2.5 KB) - added by godiard 8 years ago.
xdpyinfo output on Fedora 18
xdpyinfo_f20.log (2.4 KB) - added by godiard 8 years ago.
xdpyinfo output on Fedora 20

Download all attachments as: .zip

Change History (8)

comment:1 Changed 8 years ago by godiard

  • Component changed from Sugar to Imageviewer

comment:2 Changed 8 years ago by godiard

The same code is used in other activities:

[gonzalo@localhost honey]$ grep -r create_similar * --include=*.py
browse/mainline/webactivity.py:        thumb_surface = Gdk.Window.create_similar_surface(window,
clock/mainline/clock.py:        self._simple_background_cache = cr.get_target().create_similar(
clock/mainline/clock.py:        self._nice_background_cache = cr.get_target().create_similar(
fototoon/fototoon-activity/reorderwindow.py:        self.image = ctx.get_target().create_similar(
fototoon/fototoon-activity/historietaactivity.py:            self.image = ctx.get_target().create_similar(
fototoon/fototoon-activity/historietaactivity.py:                sav_img = ctx.get_target().create_similar(
fototoon/fototoon-activity/historietaactivity.py:            self.image = ctx.get_target().create_similar(
imageviewer/imageviewer-activity/ImageView.py:    surface = ctx.get_target().create_similar(
imageviewer/imageviewer-activity/ImageView.py:    new_surface = ctx.get_target().create_similar(
maze/maze-activity/game.py:            self._cached_surface = ctx.get_target().create_similar(
memorize/memorize-activity/svgcard.py:            context.get_target().create_similar(cairo.CONTENT_COLOR_ALPHA,
paint/paint-activity/Area.py:            self.drawing_canvas = context.get_target().create_similar(
paint/paint-activity/Area.py:            self.temp_canvas = context.get_target().create_similar(
paint/paint-activity/Area.py:        mirror_surface = surface.create_similar(cairo.CONTENT_COLOR_ALPHA,
paint/paint-activity/Area.py:        rotate_surface = surface.create_similar(cairo.CONTENT_COLOR_ALPHA,
paint/paint-activity/Area.py:            self.drawing_canvas_data = surface.create_similar(
read/read-activity/readactivity.py:        screenshot_surface = target.create_similar(cairo.CONTENT_COLOR,
turtleart/mainline/TurtleArtActivity.py:        self.turtle_canvas = cr.get_target().create_similar(
turtleart/mainline/turtleblocks.py:        self.turtle_canvas = surface.create_similar(
turtleart/mainline/pyexported/window_setup.py:        self.turtle_canvas = surface.create_similar(

Changed 8 years ago by godiard

Original image

Changed 8 years ago by godiard

How is displayed in the ImageViewer activity

Changed 8 years ago by godiard

xdpyinfo output on Fedora 18

Changed 8 years ago by godiard

xdpyinfo output on Fedora 20

comment:4 Changed 8 years ago by godiard

  • Resolution set to fixed
  • Status changed from new to closed

Fixed by 071ba2ebd06e58ca98fd4a3c94d21888f62012d7
Version 60

Note: See TracTickets for help on using tickets.