sugar-install-bundle: fails to update activity list view after activity upgrade

[quozl]

sugar-install-bundle did not update the activity list view with a new version number after an activity was upgraded.

Reproducer:

• install OLPC AU 33027xx4.zd or similar,
• note the version of TurtleBlocks shown in activity list view, 195.2,
• start Terminal and wget ​http://people.sugarlabs.org/~walter/TurtleBlocks-196.1.xo
• use sugar-install-bundle to upgrade the activity,
• issue: note the version shown has not changed, still 195.2.

Workaround 1: restart Sugar.

Workaround 2: use Browse to download and install.

Workaround 3: use Journal and USB drive to install.

See also #235.

[Sam Parkinson]

Use the bundle registry in sugar-install-bundle; fixes #4722

The bundle registry properly signals the activity list to update its entries,
whereas directly installing the bundle does not emit any signals (unless it is
an install or uninstall).

Changeset: d0d045379f097e35c686e9f5dc7f1a0a231041bd

[quozl]

Thanks, but it is speculated that your patch breaks use of sugar-install-bundle when the display, dbus and Sugar shell are not present. Please rewrite and test in a process cleaned of environment variables. It is fine for the activity list not to be updated in such a scenario.

[Martin Abente Lahaye]

Revert "Use the bundle registry in sugar-install-bundle; fixes #4722"

This reverts commit d0d045379f097e35c686e9f5dc7f1a0a231041bd.

Changeset: 212d671062b7db9f8f47e057168cbec809b73ed2

[quozl]

Caused #4849.

The bundle registry already had calls to Gio.FileMonitor for the $HOME/Activities directory, so it should have been detecting the new or upgraded activity.