Browse: improve bookmarks management

[godiard]

Paul Cotton from OLPC AU said:

"So below are the two options that make sense to me. Hopefully one of those two options is consistent with general behaviour throughout Sugar. Hopefully it all makes sense to you guys as well.
Option 1: The star on the main browse nav should just open and close the favourites tray, and add/remove favourite functionality should be present in that tray. It could be that there's always an extra icon present to the right of the favourites list that is just a box with + in it. Removing favourites would be via right click or long press, as it is currently. We would also remove the favourite tray icon that sits under the eye icon/menu.
Option 2: The star should be used to add the current site as a favourite, and signify that the current site is a favourite through a change in colour when you're on that site. Similar to the Chrome favourite star in its address bar. Favouriting a site would still bring up the tray to visually confirm that it was added and so you can see where it's placed in your list, removing it would probably do the same thing to maintain consistency. If done this way, the tray would require an X in its top right for closing it. You would also press the star to remove the favourite.

In my opinion, the first option is the most straightforward and easily understood - although the second one could probably be made a little more elegant. Let me know if you want pictures, and I will illustrate what I'm talking about. What do you think?

Just by the way, Option 1 means we don't need to add an X for closing into the favourite tray - which I imagine would get in the way when the number of favourites you have exceeds the horizontal length of the screen, as the buttons for moving between them at that point fills the entire vertical space of the tray."

I think option 2 is better, but we need think if we can add a "close" button in the Tray (can be more immediate/obvious than go to the view toolbar and use the view/hide tray button)

[manuq]

Option 1: currently the star on the main browse is a direct way to add the current page from bookmarks. By moving that behavior only to the tray, we are going to make it more indirect.

Option 2: I really like the described behavior, the star should work like in Chrome or other browsers, as a toggle. Here are my thoughts, based on yours:

• when the browser is in a page that is not bookmarked, the icon has white fill, like current implementation
• when the browser is in a page that is bookmarked, the icon is filled with the user color
• so when the user bookmarks a page, the icon turns to her/his color
• the tray appears when the star is clicked to show the addition or removal (ideally with an animation of the new element appearing or disappearing)
• there is a X icon on the right side of the bookmarks tray to close it

Thanks for the feedback!

[sam]

Adopted option 2 in ​https://github.com/sugarlabs/browse-activity/commit/d25af13602b092f03ae8a1b94857e587c72b2531

Will be part of v201 when released.