Opened 8 years ago

Closed 7 years ago

#4634 closed defect (fixed)

bundle_id with space causes most activities to disappear

Reported by: dsd Owned by:
Priority: Urgent Milestone: Unspecified
Component: Sugar Version: Unspecified
Severity: Unspecified Keywords:
Cc: Distribution/OS: Unspecified
Bug Status: New

Description

Edit an activity.info file, adding another word to the bundle_id assignment, like:

bundle_id = org.laptop.Log hello

Restart Sugar. Most activities won't appear on the home screen, since Sugar has choked on the following exception:

Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/jarabe/desktop/favoritesview.py", line 133, in __connect_to_bundle_registry_cb
    info.get_activity_version()):
  File "/usr/lib/python2.7/site-packages/jarabe/model/bundleregistry.py", line 312, in is_bundle_favorite
    key = self._get_favorite_key(bundle_id, version)
  File "/usr/lib/python2.7/site-packages/jarabe/model/bundleregistry.py", line 118, in _get_favorite_key
    raise ValueError('bundle_id cannot contain spaces')
ValueError: bundle_id cannot contain spaces

Reproduced on Sugar-0.98 and 0.96.

Change History (4)

comment:1 Changed 8 years ago by AlanJAS

This is a bad bug! Sugar cannot fail for a incorrect activity.info field.
What happens with other fields?

comment:2 Changed 8 years ago by dnarvaez

  • Bug Status changed from Unconfirmed to New
  • Priority changed from Unspecified by Maintainer to Urgent

comment:3 Changed 8 years ago by SAMdroid

I'm working on a fix for the bug at _get_favorite_key() (As part of google code in).
It is sort of working but another bug is just exposed downstream; dbus will not accept spaces in ids either. This causes dbus apps to crash (log...).

comment:4 Changed 7 years ago by Sam

  • Resolution set to fixed
  • Status changed from new to closed

Fixes #4634, issue where spaces in bundle ids crashed sugar

Changeset: f43d5f8d24819fa19f2e49bd14cd1b51ee44c2cc

Note: See TracTickets for help on using tickets.