Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#4498 closed defect (fixed)

Browse 149.2 can't finish download image

Reported by: godiard Owned by: manuq
Priority: High Milestone:
Component: Browse Version: Unspecified
Severity: Unspecified Keywords: olpc-test-pending
Cc: Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description

Code from master was included in 149.2. When try keep a image in the journal, the Journal entry show "Downloading ..." title, and is not properly downloaded.
Tested on os6.
We need this issue solved for 13.2.0
The log show:

Traceback (most recent call last):
  File "/home/olpc/Activities/Browse.activity/downloadmanager.py", line 190, in __state_change_cb
    preview = self._get_preview()
  File "/home/olpc/Activities/Browse.activity/downloadmanager.py", line 316, in _get_preview
    preview_width, preview_height = activity.PREVIEW_SIZE
AttributeError: 'module' object has no attribute 'PREVIEW_SIZE'

Change History (4)

comment:1 follow-up: Changed 8 years ago by manuq

Note how a small change can break stuff. Pushed 7606b2de and preparing release.

comment:2 Changed 8 years ago by manuq

  • Keywords olpc-test-pending added
  • Resolution set to fixed
  • Status changed from new to closed

comment:3 in reply to: ↑ 1 Changed 8 years ago by godiard

Replying to manuq:

Note how a small change can break stuff. Pushed 7606b2de and preparing release.

Be on topics ;)

Discussion of usefulness or not of tests is a separated topic.

comment:4 Changed 8 years ago by dnarvaez

  • Milestone 0.98 deleted

Milestone 0.98 deleted

Note: See TracTickets for help on using tickets.