Opened 11 years ago
Closed 10 years ago
#4493 closed defect (fixed)
Reboot and Shutdown using ConsoleKit not working
Reported by: | gaudenz | Owned by: | erikos |
---|---|---|---|
Priority: | Urgent | Milestone: | Unspecified |
Component: | Sugar | Version: | 0.98.x |
Severity: | Major | Keywords: | |
Cc: | Distribution/OS: | Unspecified | |
Bug Status: | New |
Description
Reboot and Shutdown using ConsoleKit does not work. This is because the test for systemd in jarabe/model/session.py always succeeds.
os.access returns True or False directly no need to check for >=0. This is even harmfull as Fals >= 0 evaluates to True in Python! :-(
Change History (5)
comment:1 Changed 10 years ago by dnarvaez
comment:2 Changed 10 years ago by dnarvaez
- Bug Status changed from New to Unconfirmed
comment:3 Changed 10 years ago by dnarvaez
- Bug Status changed from Unconfirmed to New
- Priority changed from Unspecified by Maintainer to Urgent
comment:4 Changed 10 years ago by tch
Is this still necessary? I just sent a pull request anyway.
comment:5 Changed 10 years ago by Martin Abente Lahaye
- Resolution set to fixed
- Status changed from new to closed
Fix systemd check
There is no need to check for the >=0 condition. Return os.access
return value directly. Fixes #4493.
Signed-off-by: Martin Abente Lahaye <tch@…>
Changeset: a6253884ea5c8e21f31991d39ce98899787e9328
Note: See
TracTickets for help on using
tickets.
Pull requests welcome :)